Re: [Lldb-commits] [PATCH] D14060: Deprecate -m/+m dotest options in favor of test categories

2015-10-27 Thread Pavel Labath via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL251400: Deprecate -m/+m dotest options in favor of test categories (authored by labath). Changed prior to commit: http://reviews.llvm.org/D14060?vs=38389=38516#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D14060: Deprecate -m/+m dotest options in favor of test categories

2015-10-26 Thread Ilia K via lldb-commits
ki.stfu accepted this revision. ki.stfu added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D14060 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D14060: Deprecate -m/+m dotest options in favor of test categories

2015-10-26 Thread Pavel Labath via lldb-commits
labath created this revision. labath added reviewers: tfiala, dawn, ki.stfu, abidh. labath added a subscriber: lldb-commits. This change deprecates -m/+m dotest options (the options are still recognized but they print an error message pointing to the new options) and adds a new lldb-mi test

Re: [Lldb-commits] [PATCH] D14060: Deprecate -m/+m dotest options in favor of test categories

2015-10-26 Thread Todd Fiala via lldb-commits
tfiala accepted this revision. tfiala added a comment. LGTM. Who currently owns the MI tests (or system) these days? I suppose you are doing this to squelch them from failing on the buildbots. On our end, we see the MI tests fail fairly frequently, typically intermittently.

Re: [Lldb-commits] [PATCH] D14060: Deprecate -m/+m dotest options in favor of test categories

2015-10-26 Thread Pavel Labath via lldb-commits
labath added a comment. We have XFAILed MI tests that were failing on our linux build bot. Atm, I am seeing expected passes, so I might try enabling them soon... However, these tests are not remote-ready, so we have to skip them on the android built bots. http://reviews.llvm.org/D14060

Re: [Lldb-commits] [PATCH] D14060: Deprecate -m/+m dotest options in favor of test categories

2015-10-26 Thread Todd Fiala via lldb-commits
tfiala added a comment. In http://reviews.llvm.org/D14060#275211, @labath wrote: > We have XFAILed MI tests that were failing on our linux build bot. Atm, I am > seeing expected passes, so I might try enabling them soon... I have been seeing them fail intermittently on both OS X and Ubuntu