Re: [Lldb-commits] [PATCH] D14083: Fix race condition in process resume

2015-10-27 Thread Pavel Labath via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL251399: Fix race condition in process resume (authored by labath). Changed prior to commit: http://reviews.llvm.org/D14083?vs=38429&id=38515#toc Repository: rL LLVM http://reviews.llvm.org/D14083 F

Re: [Lldb-commits] [PATCH] D14083: Fix race condition in process resume

2015-10-26 Thread Pavel Labath via lldb-commits
labath added inline comments. Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:1074-1079 @@ -1073,2 +1073,8 @@ +if (! broadcast_sent) +{ +BroadcastEvent(eBroadcastBitRunPacketSent, NULL); +

Re: [Lldb-commits] [PATCH] D14083: Fix race condition in process resume

2015-10-26 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good as long as we always want to send the broadcast even if the continue packet fails to send. Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicatio

[Lldb-commits] [PATCH] D14083: Fix race condition in process resume

2015-10-26 Thread Pavel Labath via lldb-commits
labath created this revision. labath added a reviewer: clayborg. labath added a subscriber: lldb-commits. Gdb-remote's async thread sent out the eBroadcastBitRunPacketSent message *before* actually sending out the continue packet. Since it's this message the actually triggers the public state tr