[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

labath added a comment. In D142926#4124297 , @bulbazord wrote: > In D142926#4123492 , @labath wrote: > >> Well... right now, there isn't anything else to do there. >> >> Anyway, I don't think this is particularly

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

bulbazord added a comment. In D142926#4133440 , @bulbazord wrote: > I'll upload a patch to handle that. D144228 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142926/new/

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

bulbazord added a comment. In D142926#4133356 , @saugustine wrote: > I don't think this necessarily matters or is a reason to revert, but we are > seeing issues with this patch and swig 3.0.2, that disappear with swig 4.0. > > The docs claim that

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

saugustine added a comment. I don't think this necessarily matters or is a reason to revert, but we are seeing issues with this patch and swig 3.0.2, that disappear with swig 4.0. The docs claim that versions past 3.0 are supported (except for some odd corner cases). The failure is:

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

This revision was automatically updated to reflect the committed changes. Closed by commit rG662548c82683: [lldb] Replace SB swig interfaces with API headers (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142926/new/

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142926/new/ https://reviews.llvm.org/D142926 ___

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

bulbazord updated this revision to Diff 497117. bulbazord added a comment. Rebasing against top of tree Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142926/new/ https://reviews.llvm.org/D142926 Files: lldb/bindings/CMakeLists.txt

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

bulbazord added a comment. In D142926#4123492 , @labath wrote: > Well... right now, there isn't anything else to do there. > > Anyway, I don't think this is particularly important. I don't know even if > the distros would like to do this or whether to

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

labath added a comment. In D142926#4103185 , @bulbazord wrote: > In D142926#4102287 , @labath wrote: > >> I like this. >> >> I'm not sure what it would take, but I think it'd be nice if the >> de-swig-ification

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

bulbazord added a comment. Does anybody have any further concerns or objections? I'd like to get this change in early next week if possible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142926/new/ https://reviews.llvm.org/D142926

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

bulbazord updated this revision to Diff 496299. bulbazord added a comment. Stop exposing unsupported SBReproducer functions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142926/new/ https://reviews.llvm.org/D142926 Files:

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

JDevlieghere added a comment. In D142926#4116427 , @clayborg wrote: > Does this mean we could submit a patch that removes all of the > "LLDB_INSTRUMENT*" stuff that is in all of the SB*.cpp files? That would be > great to clean that up if they are not

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

clayborg added a comment. In D142926#4116417 , @JDevlieghere wrote: > In D142926#4115980 , @clayborg > wrote: > >> In D142926#4115875 , @JDevlieghere >> wrote: >> >>>

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

JDevlieghere added a comment. In D142926#4115980 , @clayborg wrote: > In D142926#4115875 , @JDevlieghere > wrote: > >> In D142926#4114215 , @bulbazord >> wrote: >> >>>

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

clayborg added a comment. In D142926#4115875 , @JDevlieghere wrote: > In D142926#4114215 , @bulbazord > wrote: > >> Not sure how useful it would be but I recorded the full list of methods get >> added with

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

JDevlieghere added a comment. In D142926#4114215 , @bulbazord wrote: > Not sure how useful it would be but I recorded the full list of methods get > added with this change. Take a look and let me know if there are any that you > think shouldn't be

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

bulbazord added a comment. Not sure how useful it would be but I recorded the full list of methods get added with this change. Take a look and let me know if there are any that you think shouldn't be added. SBAttachInfo::~SBAttachInfo() SBBroadcaster::operator<(const lldb::SBBroadcaster &)

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

bulbazord added a comment. In D142926#4113600 , @clayborg wrote: > In D142926#4111717 , @bulbazord > wrote: > >> Certainly interesting: >> >> - SBListener::StopListeningForEventClass return type conflicts (ABI

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

bulbazord updated this revision to Diff 495978. bulbazord added a comment. - Removed a bunch of header guards effectively adding methods to the python bindings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142926/new/

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

clayborg added a comment. In D142926#4111717 , @bulbazord wrote: > Potentially interesting: > > - SBData::GetDescription base_addr parameter has default value now > - SBInstructionList::GetInstructionsCount canSetBreakpoint has default value > now > -

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

clayborg added a comment. In D142926#4111717 , @bulbazord wrote: > In addition to what I wrote above, I also fixed several documentation bugs > (putting docstrings on the wrong method). > > I manually audited the generated code before and after this

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

JDevlieghere added a comment. I can see how having parity between the signatures that were exposed in the interface files makes the verification easier, but do we actually want to land the patch like that? Does anyone care that we expose more? Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

bulbazord added a comment. In addition to what I wrote above, I also fixed several documentation bugs (putting docstrings on the wrong method). I manually audited the generated code before and after this change. Here are my notes: Not too interesting: - Some parameter names changed - Fixed