[Lldb-commits] [PATCH] D143127: [LLDB] Fix assertion failure by removing `CopyType` in `std::coroutine_handle` pretty printer

avogelsgesang added a comment. @labath @aprantl Thanks for your reviews! I would like to backport this fix together with the fix from https://reviews.llvm.org/D132815 to the 16.0 release branch now. For that I would need your approval on

[Lldb-commits] [PATCH] D143127: [LLDB] Fix assertion failure by removing `CopyType` in `std::coroutine_handle` pretty printer

This revision was automatically updated to reflect the committed changes. Closed by commit rG54d4a2550d31: [LLDB] Fix assertion failure by removing `CopyType` in `std::coroutine_handle`… (authored by avogelsgesang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D143127: [LLDB] Fix assertion failure by removing `CopyType` in `std::coroutine_handle` pretty printer

aprantl accepted this revision. aprantl added a comment. > Well.. I don't believe we have any ASTImporter calls in any of the other > pretty printers, so I think this change is good. And if it causes some other > issues, then maybe we need to look at solving them in some other way... Okay I

[Lldb-commits] [PATCH] D143127: [LLDB] Fix assertion failure by removing `CopyType` in `std::coroutine_handle` pretty printer

avogelsgesang added a comment. Agree, other pretty-printers also don't use `ASTImporter`. I think the call was still needed originally in https://github.com/llvm/llvm-project/commit/01f4c305fae9ff2f165ce0f635a90f8e2292308c, because the promise_type was combined with newly created AST types

[Lldb-commits] [PATCH] D143127: [LLDB] Fix assertion failure by removing `CopyType` in `std::coroutine_handle` pretty printer

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Well.. I don't believe we have any ASTImporter calls in any of the other pretty printers, so I think this change is good. And if it causes some other issues, then maybe we need to look at

[Lldb-commits] [PATCH] D143127: [LLDB] Fix assertion failure by removing `CopyType` in `std::coroutine_handle` pretty printer

avogelsgesang added a comment. > This change makes me a little nervous, but mostly because I don't quite > understand the design here. > So ASTImporter does not have a check whether src context and dst context are > identical? I am completely with you. I also don't understand the design of

[Lldb-commits] [PATCH] D143127: [LLDB] Fix assertion failure by removing `CopyType` in `std::coroutine_handle` pretty printer

aprantl added a comment. This change makes me a little nervous, but mostly because I don't quite understand the design here. So ASTImporter does not have a check whether src context and dst context are identical? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D143127: [LLDB] Fix assertion failure by removing `CopyType` in `std::coroutine_handle` pretty printer

avogelsgesang created this revision. avogelsgesang added reviewers: labath, aprantl. Herald added a subscriber: ChuanqiXu. Herald added a project: All. avogelsgesang requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The pretty printer for