[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdfdd8988621b: [lldb/crashlog] Load inlined symbol into interactive crashlog (authored by mib). Changed prior to commit:

[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

mib updated this revision to Diff 523980. mib marked 3 inline comments as done. mib added a comment. Address @kastiglione comments and reformat. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146765/new/ https://reviews.llvm.org/D146765 Files: lldb/examples/python/crashlog.py

[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

kastiglione added inline comments. Comment at: lldb/examples/python/crashlog.py:703 +symbol = ( +r'(?: +(?:' # spaces and + sign +r'(.+)' # symbol name this is just "spaces", not "spaces and +

[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Ok, looks good to me now. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146765/new/ https://reviews.llvm.org/D146765 ___

[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

mib updated this revision to Diff 523961. mib marked 4 inline comments as done. mib added a comment. Address @bulbazord comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146765/new/ https://reviews.llvm.org/D146765 Files: lldb/examples/python/crashlog.py

[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

mib marked 7 inline comments as done. mib added inline comments. Comment at: lldb/examples/python/crashlog.py:628-629 +description = "" +# Since images are parsed after threads, we need to build a +# map for every image with a list of all the

[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

bulbazord added a comment. Looks good! A few minor comments. Comment at: lldb/examples/python/crashlog.py:628-629 +description = "" +# Since images are parsed after threads, we need to build a +# map for every image with a list of all the

[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

mib updated this revision to Diff 523948. mib added a comment. Address feedbacks: - Simplify and Improve regex - Add test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146765/new/ https://reviews.llvm.org/D146765 Files: lldb/examples/python/crashlog.py

[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

mib marked 2 inline comments as done. mib added inline comments. Comment at: lldb/examples/python/crashlog.py:669 + r'(0x[0-9a-fA-F]{4,}) +' # addr (4 chars or more) + r'((.*)(?:(?: +\+ +)([0-9]+))|[^\s]+)' #

[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

kastiglione added inline comments. Comment at: lldb/examples/python/crashlog.py:669 + r'(0x[0-9a-fA-F]{4,}) +' # addr (4 chars or more) + r'((.*)(?:(?: +\+ +)([0-9]+))|[^\s]+)' # symbol + offset

[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

mib updated this revision to Diff 511805. mib marked 7 inline comments as done and an inline comment as not done. mib added a comment. Address some of the comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146765/new/ https://reviews.llvm.org/D146765 Files:

[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

JDevlieghere added inline comments. Comment at: lldb/examples/python/crashlog.py:1187-1192 +symbol_file = os.path.join(tmp_dir.name, module.GetUUIDString() + ".json") +with open(symbol_file, 'w') as f: +f.write(json.dumps(symbol_data)) + +

[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

kastiglione added inline comments. Comment at: lldb/examples/python/crashlog.py:669 + r'(0x[0-9a-fA-F]{4,}) +' # addr (4 chars or more) + r'((.*)(?:(?: +\+ +)([0-9]+))|[^\s]+)' # symbol + offset

[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

mib added inline comments. Comment at: lldb/examples/python/crashlog.py:540 +image = self.get_used_image(image_id) frame_offset = int(json_frame['imageOffset']) bulbazord wrote: > is `image` not the same as `json_image` from a few

[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

bulbazord added inline comments. Comment at: lldb/examples/python/crashlog.py:540 +image = self.get_used_image(image_id) frame_offset = int(json_frame['imageOffset']) is `image` not the same as `json_image` from a few lines above this?

[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

kastiglione added inline comments. Comment at: lldb/examples/python/crashlog.py:669 + r'(0x[0-9a-fA-F]{4,}) +' # addr (4 chars or more) + r'((.*)(?:(?: +\+ +)([0-9]+))|[^\s]+)' # symbol + offset

[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

mib added inline comments. Comment at: lldb/examples/python/crashlog.py:552-557 +self.symbol_data[image_uuid]["symbols"].append({ +"name": json_frame['symbol'], +"type": "code", +"size": 0, +

[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

mib created this revision. mib added reviewers: JDevlieghere, kastiglione, bulbazord. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. Sometimes, crash reports come with inlined symbols. These provide the exact