[Lldb-commits] [PATCH] D147606: [lldb] fix #61942, discard "empty" ranges in DWARF to better handle gcc binary

jwnhy added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147606/new/ https://reviews.llvm.org/D147606 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D147606: [lldb] fix #61942, discard "empty" ranges in DWARF to better handle gcc binary

jwnhy added a comment. In D147606#4246832 , @JDevlieghere wrote: > The change looks fine and regardless of whether this makes sense or even > complies with the standard, we should be resilient against it. I would like > to see a test though. It seems

[Lldb-commits] [PATCH] D147606: [lldb] fix #61942, discard "empty" ranges in DWARF to better handle gcc binary

jwnhy updated this revision to Diff 512362. jwnhy added a comment. Updated the patch to remove unncessary checks and added a testcase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147606/new/ https://reviews.llvm.org/D147606 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp

[Lldb-commits] [PATCH] D147606: [lldb] fix #61942, discard "empty" ranges in DWARF to better handle gcc binary

labath added a comment. In D147606#4249283 , @JDevlieghere wrote: > In D147606#4247462 , @jwnhy wrote: > >> In D147606#4246832 , @JDevlieghere >> wrote: >> >>> The

[Lldb-commits] [PATCH] D147606: [lldb] fix #61942, discard "empty" ranges in DWARF to better handle gcc binary

JDevlieghere added a comment. In D147606#4247462 , @jwnhy wrote: > In D147606#4246832 , @JDevlieghere > wrote: > >> The change looks fine and regardless of whether this makes sense or even >> complies with the

[Lldb-commits] [PATCH] D147606: [lldb] fix #61942, discard "empty" ranges in DWARF to better handle gcc binary

jwnhy added a comment. In D147606#4246832 , @JDevlieghere wrote: > The change looks fine and regardless of whether this makes sense or even > complies with the standard, we should be resilient against it. I would like > to see a test though. Thanks a

[Lldb-commits] [PATCH] D147606: [lldb] fix #61942, discard "empty" ranges in DWARF to better handle gcc binary

jwnhy added a comment. In D147606#4245804 , @DavidSpickett wrote: > I'm not familiar with this code, but the issue as explained I think I > understand. > > It seems like you're checking for empty ranges in two places, what does each > one do? > > Is

[Lldb-commits] [PATCH] D147606: [lldb] fix #61942, discard "empty" ranges in DWARF to better handle gcc binary

JDevlieghere added a comment. The change looks fine and regardless of whether this makes sense or even complies with the standard, we should be resilient against it. I would like to see a test though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D147606: [lldb] fix #61942, discard "empty" ranges in DWARF to better handle gcc binary

DavidSpickett added a comment. I'm not familiar with this code, but the issue as explained I think I understand. It seems like you're checking for empty ranges in two places, what does each one do? Is there anything else these ranges indicate or do we think it is simply a missed optimisation

[Lldb-commits] [PATCH] D147606: [lldb] fix #61942, discard "empty" ranges in DWARF to better handle gcc binary

jwnhy created this revision. jwnhy added reviewers: Michael137, DavidSpickett, JDevlieghere. Herald added a project: All. jwnhy requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch resolves an issue that lldb not be able to match the