[Lldb-commits] [PATCH] D149482: [lldb] Change ObjectValueDictionary to use a StringMap

This revision was automatically updated to reflect the committed changes. Closed by commit rGe53e1de57ecc: [lldb] Change ObjectValueDictionary to use a StringMap (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149482/new/

[Lldb-commits] [PATCH] D149482: [lldb] Change ObjectValueDictionary to use a StringMap

bulbazord updated this revision to Diff 518569. bulbazord added a comment. Remove unneeded StringRef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149482/new/ https://reviews.llvm.org/D149482 Files:

[Lldb-commits] [PATCH] D149482: [lldb] Change ObjectValueDictionary to use a StringMap

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Core/Disassembler.cpp:805 - ConstString const_key(key.c_str()); + llvm::StringRef key_ref(key); // Check value to

[Lldb-commits] [PATCH] D149482: [lldb] Change ObjectValueDictionary to use a StringMap

bulbazord updated this revision to Diff 518542. bulbazord added a comment. Sort output for dumping to be deterministic (based on alphabetical order like previous implementation) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149482/new/

[Lldb-commits] [PATCH] D149482: [lldb] Change ObjectValueDictionary to use a StringMap

JDevlieghere reopened this revision. JDevlieghere added a comment. That's my bad: I put the wrong differential URL in my commit (13dbc16b4d82b9adc98c0919873b2b59ccc46afd ) Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D149482: [lldb] Change ObjectValueDictionary to use a StringMap

jingham added a comment. I think something went wrong here. This was a patch for OptionValueDictionary, but it seems to have become a patch for OpenInExternalEditor? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149482/new/

[Lldb-commits] [PATCH] D149482: [lldb] Change ObjectValueDictionary to use a StringMap

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG13dbc16b4d82: [lldb] Refactor host::OpenFileInExternalEditor (authored by JDevlieghere). Changed prior to commit:

[Lldb-commits] [PATCH] D149482: [lldb] Change ObjectValueDictionary to use a StringMap

JDevlieghere added a comment. +1 on making the output deterministic with a sort Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149482/new/ https://reviews.llvm.org/D149482 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D149482: [lldb] Change ObjectValueDictionary to use a StringMap

bulbazord added inline comments. Comment at: lldb/source/Core/Disassembler.cpp:846 +// Note: The reason we are making the data_type a uint64_t when value is +// uint32_t is that there is no eTypeUInt32 enum value. +if (llvm::StringRef(value) ==

[Lldb-commits] [PATCH] D149482: [lldb] Change ObjectValueDictionary to use a StringMap

jingham added a comment. No reason for these strings to be in the ConstString pool, so that part is fine. But if we're going to use this to store things like the env-vars, having no ordering guarantees when we dump them seems likely to be a bit annoying. If the order of element output in

[Lldb-commits] [PATCH] D149482: [lldb] Change ObjectValueDictionary to use a StringMap

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham, jasonmolenda. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. llvm has a structure for maps where the key's type