This revision was automatically updated to reflect the committed changes.
Closed by commit rGdb5f745a2bfc: [lldb] Make some functions useful to REPLs
public (authored by wallace).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149717/new/
bulbazord accepted this revision.
bulbazord added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149717/new/
https://reviews.llvm.org/D149717
wallace updated this revision to Diff 519542.
wallace added a comment.
address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149717/new/
https://reviews.llvm.org/D149717
Files:
lldb/include/lldb/Core/Debugger.h
Index:
JDevlieghere added inline comments.
Comment at: lldb/include/lldb/Core/Debugger.h:505
+ /// that directly use the \a lldb_private namespace and want to use the
+ /// default LLDB event handler thread instead of defining their own.
+ bool StartEventHandlerThread();
wallace updated this revision to Diff 519141.
wallace added a comment.
address comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149717/new/
https://reviews.llvm.org/D149717
Files:
lldb/include/lldb/Core/Debugger.h
Index:
wallace added inline comments.
Comment at: lldb/include/lldb/Core/Debugger.h:503-504
+ /// Manually start the global event handler thread. It should be used by
+ /// programs that use LLDB as a library.
+ bool StartEventHandlerThread();
bulbazord wrote:
>
bulbazord added a reviewer: JDevlieghere.
bulbazord added inline comments.
Comment at: lldb/include/lldb/Core/Debugger.h:503-504
+ /// Manually start the global event handler thread. It should be used by
+ /// programs that use LLDB as a library.
+ bool
wallace created this revision.
Herald added a project: All.
wallace requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
`StartEventHandlerThread` and `StopEventHandlerThread` are available to the
SwiftREPL even though they are protected
