tberghammer added a comment.
What is the opinion about adding just a boolean flag to specify if the path
provided is a local path or a remote path? In case it is a remote path (will be
the default to keep current behavior) then we don't do any copying and if it is
a local path then we copy the
clayborg added a comment.
Maybe Platform::LoadImage() should keep its current arguments and the path that
is specified should always be correct for the platform. Other code should do
the copy over if it needs to and call Platform::LoadImage() with a path that
makes sense for the platform. The
tberghammer added a comment.
I would like to exposed the ability to specify if we want the specified file to
be copied over to the target or not both at the command line and on the SB API.
To do this without duplicating the logic what do the file installation into
CommandObjectProcess and
tberghammer added a comment.
Sounds reasonable. The only question is that currently only PlatformPOSIX
supports LoadImage. Do we want to add the DoLoadImage function now, or do we
want to wait until some other platform also want to implement image loading?
http://reviews.llvm.org/D15152
tberghammer created this revision.
tberghammer added reviewers: labath, clayborg.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer, emaste.
Change Platform::LoadImage to copy the file to the remote platform
The new implementation mimic the behavior
jingham added a subscriber: jingham.
jingham added a comment.
We use process load to load images that are already extant (and system
libraries at that.) So it's got to be possible to load a library into a target
process without trying to get the image over to the target. And given how slow
