jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
OK. It would have been better to make a patch that fixes the specific problem
with other C variants. That's just a straight up bug, and mixing it with
comments on the two separate issues,
This revision was automatically updated to reflect the committed changes.
Closed by commit rL254753: Fix breakpoint language filtering for other C
variants (like C99) and Pascal. (authored by dperchik).
Changed prior to commit:
http://reviews.llvm.org/D15175?vs=41713=41902#toc
Repository:
dawn added a comment.
Jim, this patch doesn't attempt to fix the issue I raised in my comment - it
just fixes the oversight of other C variants (clang picks C99 for example) and
renames your function to a more meaningful name (and matches
Mangled::GuessLanguage which is also uses the name to
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
If we really can't tell whether a symbol is CPP or Pascal based on the name,
then GetLanguageForSymbolByName should be reworked to take a std::vector& in
which to return the
dawn created this revision.
dawn added a reviewer: jingham.
dawn added a subscriber: lldb-commits.
dawn set the repository for this revision to rL LLVM.
This patch fixes setting breakpoints on symbol for variants of C and Pascal
where the language is "unknown" within the filtering process added
