[Lldb-commits] [PATCH] D151811: [lldb] Take StringRef name in GetIndexOfChildWithName (NFC)

2023-06-01 Thread Dave Lee via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG5dae706259da: [lldb] Take StringRef name in GetIndexOfChildWithName (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D151811: [lldb] Take StringRef name in GetIndexOfChildWithName (NFC)

2023-06-01 Thread Dave Lee via Phabricator via lldb-commits
kastiglione added inline comments. Comment at: lldb/source/Core/ValueObjectSyntheticFilter.cpp:338 if (!did_find && m_synth_filter_up != nullptr) { uint32_t index = m_synth_filter_up->GetIndexOfChildWithName(name); if (index == UINT32_MAX)

[Lldb-commits] [PATCH] D151811: [lldb] Take StringRef name in GetIndexOfChildWithName (NFC)

2023-05-31 Thread Michael Buch via Phabricator via lldb-commits
Michael137 accepted this revision. Michael137 added a comment. This revision is now accepted and ready to land. lgtm Comment at: lldb/source/Core/ValueObjectSyntheticFilter.cpp:338 if (!did_find && m_synth_filter_up != nullptr) { uint32_t index =

[Lldb-commits] [PATCH] D151811: [lldb] Take StringRef name in GetIndexOfChildWithName (NFC)

2023-05-31 Thread Dave Lee via Phabricator via lldb-commits
kastiglione created this revision. kastiglione added reviewers: bulbazord, jingham. Herald added a subscriber: arphaman. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. As with D151615