[Lldb-commits] [PATCH] D151966: [lldb] Default can_create to true in GetChildMemberWithName (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG7d4fcd411b3d: [lldb] Default can_create to true in GetChildMemberWithName (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D151966: [lldb] Default can_create to true in GetChildMemberWithName (NFC)

bulbazord accepted this revision. bulbazord added a comment. I'm alright with this if Jim is. I think we should remove this parameter since it's never set to anything other than `true` from what I understand, but that can be done in a follow-up. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D151966: [lldb] Default can_create to true in GetChildMemberWithName (NFC)

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. It's OK to retain this as the default, and as you say, taking it out would be a trivial patch after this work. The control does allow you to do "Have I already made this child" before

[Lldb-commits] [PATCH] D151966: [lldb] Default can_create to true in GetChildMemberWithName (NFC)

kastiglione added a comment. To expand the conversation, I have also opened D152031 which makes the same change to `GetChildAtIndex`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151966/new/

[Lldb-commits] [PATCH] D151966: [lldb] Default can_create to true in GetChildMemberWithName (NFC)

kastiglione added a comment. correction: there's still an overload of `GetChildAtNamePath`, which takes a can_create value and passes it through to `GetChildMemberWithName`. However that function isn't used, and could be deleted. To delete the parameter, that overload of

Re: [Lldb-commits] [PATCH] D151966: [lldb] Default can_create to true in GetChildMemberWithName (NFC)

That's an option too, which I considered. I went with this as a more conservative change. If there's agreement to remove it then I can change it. On Thursday, June 1, 2023, Alex Langford via Phabricator < revi...@reviews.llvm.org> wrote: > bulbazord added a comment. > > If every caller sets this

[Lldb-commits] [PATCH] D151966: [lldb] Default can_create to true in GetChildMemberWithName (NFC)

bulbazord added a comment. If every caller sets this to true, why not remove the argument altogether? It looks like `ValueObjectRegister::GetChildMemberWithName` doesn't use the argument, `ValueObject::GetChildMemberWithName` and `ValueObjectSynthetic::GetChildMemberWithName` just pass it

[Lldb-commits] [PATCH] D151966: [lldb] Default can_create to true in GetChildMemberWithName (NFC)

kastiglione created this revision. kastiglione added reviewers: jingham, bulbazord. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. It turns out all existing callers of `GetChildMemberWithName` pass