[Lldb-commits] [PATCH] D153043: [lldb] Fix handling of cfi_restore in the unwinder

Michael137 added a comment. This is now failing with: clang: warning: argument unused during compilation: '-fmodules-cache-path=/Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/lldb-test-build.noindex/module-cache-clang/lldb-shell' [-Wunused-command-line-argument] Undefined symbols

[Lldb-commits] [PATCH] D153043: [lldb] Fix handling of cfi_restore in the unwinder

jarin added a comment. In D153043#4427660 , @Michael137 wrote: > Looks like this is failing on the Darwin x86_64 buildbots: > https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/56510/execution/node/74/log/ > > Exit Code: 1 > > Command Outp

[Lldb-commits] [PATCH] D153043: [lldb] Fix handling of cfi_restore in the unwinder

Michael137 added a comment. Looks like this is failing on the Darwin x86_64 buildbots: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/56510/execution/node/74/log/ Exit Code: 1 Command Output (stderr): -- clang: warning: argument unused during compilation: '-fmodules-cache-

[Lldb-commits] [PATCH] D153043: [lldb] Fix handling of cfi_restore in the unwinder

This revision was automatically updated to reflect the committed changes. Closed by commit rG07b9e6ed0db2: [lldb] Fix handling of cfi_restore in the unwinder (authored by jarin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153043/new/ https://revi

[Lldb-commits] [PATCH] D153043: [lldb] Fix handling of cfi_restore in the unwinder

jarin updated this revision to Diff 531987. jarin added a comment. Added a comment explaining that we are restoring the caller's value of the register. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153043/new/ https://reviews.llvm.org/D153043 Files: lldb/source/Symbol/DWARFCallFrame

[Lldb-commits] [PATCH] D153043: [lldb] Fix handling of cfi_restore in the unwinder

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. I can see why the existing code is written as it is, given the dwarf spec for DW_CFA_restore: "The DW_CFA_restore instruction takes a single operand (encoded with the opcode) that

[Lldb-commits] [PATCH] D153043: [lldb] Fix handling of cfi_restore in the unwinder

jarin created this revision. jarin added a reviewer: labath. jarin added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jarin requested review of this revision. Herald added a subscriber: lldb-commits. Currently, lldb's unwinder ignores cfi_restore opcodes f