[Lldb-commits] [PATCH] D153636: [LLDB] Fix the use of "platform process launch" with no extra arguments

2023-06-29 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett added a comment. Relanded as https://github.com/llvm/llvm-project/commit/728101f97286c1665814e74686c083a4d5ff208c. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153636/new/ https://reviews.llvm.org/D153636 __

[Lldb-commits] [PATCH] D153636: [LLDB] Fix the use of "platform process launch" with no extra arguments

2023-06-28 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett added inline comments. Comment at: lldb/test/API/commands/platform/process/launch/TestPlatformProcessLaunch.py:50 +self.runCmd("settings set target.run-args D E") +self.runCmd("platform process launch --stdout {}".format(outfile)) +self.runC

[Lldb-commits] [PATCH] D153636: [LLDB] Fix the use of "platform process launch" with no extra arguments

2023-06-27 Thread Dave Lee via Phabricator via lldb-commits
kastiglione added inline comments. Comment at: lldb/test/API/commands/platform/process/launch/TestPlatformProcessLaunch.py:50 +self.runCmd("settings set target.run-args D E") +self.runCmd("platform process launch --stdout {}".format(outfile)) +self.runCmd

[Lldb-commits] [PATCH] D153636: [LLDB] Fix the use of "platform process launch" with no extra arguments

2023-06-27 Thread Dave Lee via Phabricator via lldb-commits
kastiglione added a subscriber: jingham. kastiglione added a comment. Thanks to @jingham's help in identifying this issue, I have opened https://reviews.llvm.org/D153922 as a potential fix for the issue on macOS. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[Lldb-commits] [PATCH] D153636: [LLDB] Fix the use of "platform process launch" with no extra arguments

2023-06-27 Thread Dave Lee via Phabricator via lldb-commits
kastiglione added inline comments. Comment at: lldb/test/API/commands/platform/process/launch/TestPlatformProcessLaunch.py:50 +self.runCmd("settings set target.run-args D E") +self.runCmd("platform process launch --stdout {}".format(outfile)) +self.runCmd

[Lldb-commits] [PATCH] D153636: [LLDB] Fix the use of "platform process launch" with no extra arguments

2023-06-27 Thread Dave Lee via Phabricator via lldb-commits
kastiglione added a comment. I will try to reproduce. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153636/new/ https://reviews.llvm.org/D153636 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D153636: [LLDB] Fix the use of "platform process launch" with no extra arguments

2023-06-27 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett added a comment. Do you or anyone else have a Mac they can reproduce this on? I don't. I know it works on Linux so far, unfortunately our Windows bot is down temporarily. I looked around similar tests and didn't see any skips for Mac. Sometimes the packet log will tell us more, I

[Lldb-commits] [PATCH] D153636: [LLDB] Fix the use of "platform process launch" with no extra arguments

2023-06-27 Thread Felipe de Azevedo Piovezan via Phabricator via lldb-commits
fdeazeve added a comment. I think this may have caused an LLDB test to fail: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/56977/execution/node/74/log/ runCmd: platform process launch --stdout /Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/lldb-test-build.noindex/command

[Lldb-commits] [PATCH] D153636: [LLDB] Fix the use of "platform process launch" with no extra arguments

2023-06-27 Thread David Spickett via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGcc0fc3585405: [LLDB] Fix the use of "platform process launch" with no extra arguments (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D153636: [LLDB] Fix the use of "platform process launch" with no extra arguments

2023-06-26 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Thanks for fixing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153636/new/ https://reviews.llvm.org/D153636

[Lldb-commits] [PATCH] D153636: [LLDB] Fix the use of "platform process launch" with no extra arguments

2023-06-23 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett added a reviewer: labath. DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. https://github.com/llvm/llvm-project/issues/62068 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153636/new/ https://reviews.llvm.org/D15

[Lldb-commits] [PATCH] D153636: [LLDB] Fix the use of "platform process launch" with no extra arguments

2023-06-23 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This fixes #62068. After 8d1de7b34af46a089eb5433c700419ad9b2923ee