[Lldb-commits] [PATCH] D153921: [lldb] Assert index is valid in DWARFDeclContext

2023-06-27 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rG7d04c886f9e7: [lldb] Assert index is valid in DWARFDeclContext (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://r

[Lldb-commits] [PATCH] D153921: [lldb] Assert index is valid in DWARFDeclContext

2023-06-27 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDeclContext.h:58 Entry &operator[](uint32_t idx) { -// "idx" must be valid +assert(idx < m_entries.size() && "invalid index");

[Lldb-commits] [PATCH] D153921: [lldb] Assert index is valid in DWARFDeclContext

2023-06-27 Thread Felipe de Azevedo Piovezan via Phabricator via lldb-commits
fdeazeve added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDeclContext.h:58 Entry &operator[](uint32_t idx) { -// "idx" must be valid +assert(idx < m_entries.size() && "invalid index"); return m_entries[idx]; Note the di

[Lldb-commits] [PATCH] D153921: [lldb] Assert index is valid in DWARFDeclContext

2023-06-27 Thread Felipe de Azevedo Piovezan via Phabricator via lldb-commits
fdeazeve accepted this revision. fdeazeve added a comment. This revision is now accepted and ready to land. Thanks for doing this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153921/new/ https://reviews.llvm.org/D153921 ___ lldb-commits mai

[Lldb-commits] [PATCH] D153921: [lldb] Assert index is valid in DWARFDeclContext

2023-06-27 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere created this revision. JDevlieghere added a reviewer: fdeazeve. Herald added a subscriber: arphaman. Herald added a project: All. JDevlieghere requested review of this revision. Address my own comment from D153867 . https://reviews.llvm.org/D153921