[Lldb-commits] [PATCH] D154907: [LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate (2nd attempt)

2023-07-24 Thread David Blaikie via Phabricator via lldb-commits
dblaikie added a comment. Filed https://github.com/llvm/llvm-project/issues/64093 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154907/new/ https://reviews.llvm.org/D154907 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D154907: [LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate (2nd attempt)

2023-07-24 Thread David Blaikie via Phabricator via lldb-commits
dblaikie added a subscriber: jmorse. dblaikie added a comment. Simple clang example that produces this invalid DWARF: void b(double); void c(); void e(double e) { c(); b(e); } $ clang-tot x.ii -g -c -o - -O3 | llvm-dwarfdump-tot - | grep DW_OP_deref_size

[Lldb-commits] [PATCH] D154907: [LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate (2nd attempt)

2023-07-19 Thread David Blaikie via Phabricator via lldb-commits
dblaikie added inline comments. Comment at: lldb/source/Expression/DWARFExpression.cpp:1082-1089 void *src = (void *)stack.back().GetScalar().ULongLong(); intptr_t ptr; ::memcpy(, src, sizeof(void *)); // I can't decide whether the size

[Lldb-commits] [PATCH] D154907: [LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate (2nd attempt)

2023-07-19 Thread David Blaikie via Phabricator via lldb-commits
dblaikie added a comment. In D154907#4487335 , @jasonmolenda wrote: > This looks good to me, thanks for digging in Caroline! Is there a naughty > compiler emitting this, or are we mis-parsing somehow? In D154907#4487523

[Lldb-commits] [PATCH] D154907: [LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate (2nd attempt)

2023-07-10 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda added a comment. Herald added subscribers: Michael137, JDevlieghere. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154907/new/ https://reviews.llvm.org/D154907 ___ lldb-commits

[Lldb-commits] [PATCH] D154907: [LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate (2nd attempt)

2023-07-10 Thread Caroline Tice via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG3885ceafa934: [LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate (authored by cmtice). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github