This revision was automatically updated to reflect the committed changes.
Closed by commit rL257322: Make the aarch64 lldb-server capable of debugging
arm32 applications (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D15533?vs=42987=44454#toc
Repository:
rL LLVM
omjavaid added a subscriber: omjavaid.
omjavaid added a comment.
LGTM.
I think we should submit this patch as tberghammer explained.
http://reviews.llvm.org/D15533
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
LGTM.
I think we should submit this patch as tberghammer explained.
On 8 January 2016 at 19:24, Tamas Berghammer wrote:
> tberghammer added a comment.
>
> @omjavaid: What is your opinion about submitting this patch in its current
> form with knowing that setting
tberghammer added a comment.
@omjavaid: What is your opinion about submitting this patch in its current form
with knowing that setting watchpoints from a 64bit lldb-server into 32bit
inferior will fail?
I think this patch is a step in the good direction to make a 64bit lldb-server
capable of
tberghammer added a comment.
I don't fully understand how the ptrace API works in the aarch64 Linux kernel
but based on my experiments the arm specific ptrace calls aren't working
(returning -EIO for a reason unknown to me at the moment). Because of this, the
current watchpoint implementation
tberghammer updated this revision to Diff 42987.
tberghammer added a comment.
Fix type
http://reviews.llvm.org/D15533
Files:
source/Host/common/HostInfoBase.cpp
source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.cpp
source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.h
tberghammer marked an inline comment as done.
tberghammer added a comment.
http://reviews.llvm.org/D15533
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tberghammer added a comment.
Note: This change is blocked by http://reviews.llvm.org/D15529. If that one
will get rejected then we have to move some of the 32 <-> 64 architecture
matching code into LLDB.
Comment at:
tberghammer created this revision.
tberghammer added reviewers: omjavaid, ovyalov.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer, rengolin, aemerson.
Make the aarch64 lldb-server capable of debugging arm32 applications
After this change
ovyalov accepted this revision.
This revision is now accepted and ready to land.
Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.cpp:973
@@ +972,3 @@
+{
+// PTRACE_PEEKUSER don't work in the aarch64 liux kernel used on android
devices (always return
+
10 matches
Mail list logo