This revision was automatically updated to reflect the committed changes.
Closed by commit rG165f45a87774: [lldb][lldb-vscode] Pretty print JSON to log
files (authored by DavidSpickett).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156979/new/
http
wallace accepted this revision.
wallace added a comment.
This revision is now accepted and ready to land.
nice improvement for sure
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156979/new/
https://reviews.llvm.org/D156979
DavidSpickett added reviewers: ashgti, wallace.
DavidSpickett added a comment.
The one disadvantage here is that pretty printing adds more characters, so
before you could copy paste the single JSON line and (I presume) it would have
the same number of characters.
If that's a required use case t
DavidSpickett created this revision.
Herald added a project: All.
DavidSpickett requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
This makes anlysing test failures much more easy.
For SendJSON this is simple, just use llvm::format instead.