jasonmolenda closed this revision.
jasonmolenda added a comment.
Landed in r257117.
Sendinginclude/lldb/Target/Process.h
Sendinginclude/lldb/Target/Thread.h
Sendinginclude/lldb/Target/ThreadPlanStepOut.h
Sendingsource/Target/Process.cpp
Sending
jasonmolenda added a comment.
Thanks for the comments. As for calling Clear() on the instruction list
manually, I was aping the dtor on ThreadPlanStepRange which reads,
// FIXME: The DisassemblerLLVMC has a reference cycle and won't go away if it
has any active instructions.
// I'll fix
jasonmolenda updated this revision to Diff 44189.
jasonmolenda added a comment.
Updated to address Jim's first round of comments.
1. fix typeo in comment
2. update change argument name from "private_step_out" to
"continue_to_next_branch"
3. Change continue_to_next_branch argument to have a
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
I don't so much mind that you couldn't reuse
AdvanceAddressToNextBranchInstruction, we wouldn't be using the "get the
disassembly" part of it, which is the biggest bit, since
jasonmolenda created this revision.
jasonmolenda added a reviewer: jingham.
jasonmolenda added a subscriber: lldb-commits.
jasonmolenda set the repository for this revision to rL LLVM.
Herald added a subscriber: aemerson.
When lldb is instruction stepping (or fast-stepping / instruction stepping)