This revision was automatically updated to reflect the committed changes.
Closed by commit rGc5f81100e447: When ProcessMachCore has metadata for a
binary, dont scan (authored by jasonmolenda).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
jasonmolenda updated this revision to Diff 548364.
jasonmolenda added a comment.
Rebase on current TOT sources, and add a comment to the
ProcessMachCore::LoadBinariesViaMetadata prototype in the header documenting
the meaning of the return value, I agree with Alex I should make this a little
bulbazord accepted this revision.
bulbazord added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157168/new/
https://reviews.llvm.org/D157168
JDevlieghere added inline comments.
Comment at: lldb/source/Plugins/Process/mach-core/ProcessMachCore.h:89
void CreateMemoryRegions();
- void LoadBinariesViaMetadata();
+ bool LoadBinariesViaMetadata();
void LoadBinariesViaExhaustiveSearch();
bulbazord
bulbazord added a comment.
Patch looks good to me, one small suggestion about naming.
Comment at: lldb/source/Plugins/Process/mach-core/ProcessMachCore.h:89
void CreateMemoryRegions();
- void LoadBinariesViaMetadata();
+ bool LoadBinariesViaMetadata();
void
jasonmolenda created this revision.
jasonmolenda added reviewers: bulbazord, JDevlieghere.
jasonmolenda added a project: LLDB.
Herald added a project: All.
jasonmolenda requested review of this revision.
Herald added a subscriber: lldb-commits.
We have some corefiles which are intended to debug a
