[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

wallace added a comment. > add a way to make an SBTypeSynthetic from the appropriate C++ class That's a great idea. Once we implement a couple of providers for our plugin I'll revisit the idea. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

jingham added a comment. Sorry, I got distracted, but after the fact I also agree this is reasonable. We might actually be able to support externally adding C++ based synthetic providers, though I think the best way to do that is to add a way to make an SBTypeSynthetic from the appropriate C++

[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

This revision was automatically updated to reflect the committed changes. Closed by commit rG79d5d9a0824d: [lldb] Allow synthetic providers in C++ and fix linking problems (authored by wallace). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. For the sake of unblocking this diff, I'm accepting it because there's no clear actionable feedback at the moment. @electriclilies, please follow up any feedback that is submitted

[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

wallace added a comment. In D158010#4617611 , @electriclilies wrote: > @wallace The type synthetic add command already disables itself if python is > not enabled (the check is at CommandObjectType::1564), so I think there > aren't any changes I need

[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

electriclilies added a comment. @wallace The type synthetic add command already disables itself if python is not enabled (the check is at CommandObjectType::1564), so I think there aren't any changes I need to make Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

wallace added inline comments. Comment at: lldb/source/Commands/CommandObjectType.cpp:2174 -#if LLDB_ENABLE_PYTHON - wallace wrote: > electriclilies wrote: > > jingham wrote: > > > electriclilies wrote: > > > > rriddle wrote: > > > > > Why is this dropped? > >

[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

wallace added inline comments. Comment at: lldb/source/Commands/CommandObjectType.cpp:2174 -#if LLDB_ENABLE_PYTHON - electriclilies wrote: > jingham wrote: > > electriclilies wrote: > > > rriddle wrote: > > > > Why is this dropped? > > > Walter and I want to

[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

electriclilies added a comment. @jingham Any other changes I should make? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158010/new/ https://reviews.llvm.org/D158010 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

electriclilies updated this revision to Diff 550795. electriclilies added a comment. Fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158010/new/ https://reviews.llvm.org/D158010 Files: lldb/include/lldb/DataFormatters/TypeSynthetic.h

[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

electriclilies added inline comments. Comment at: lldb/source/Commands/CommandObjectType.cpp:2174 -#if LLDB_ENABLE_PYTHON - jingham wrote: > electriclilies wrote: > > rriddle wrote: > > > Why is this dropped? > > Walter and I want to use the synthetic types

[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

jingham added inline comments. Comment at: lldb/source/Commands/CommandObjectType.cpp:2174 -#if LLDB_ENABLE_PYTHON - electriclilies wrote: > rriddle wrote: > > Why is this dropped? > Walter and I want to use the synthetic types from C++, but right now it's >

[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

electriclilies added inline comments. Comment at: lldb/include/lldb/DataFormatters/TypeSynthetic.h:257-262 + virtual bool IsScripted(); - virtual std::string GetDescription() = 0; + virtual std::string GetDescription(); virtual SyntheticChildrenFrontEnd::AutoPointer +

[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

rriddle added a comment. Moving the constructor/destructor to the cpp file makes sense to remove the "undefined reference to vtable" issues that we've seen before, but I don't understand the changes to pure virtual methods or the removal of the LLDB_ENABLE_PYTHON checks. Can you elaborate

[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

bulbazord added reviewers: jingham, augusto2112, kastiglione. bulbazord added a comment. Herald added a subscriber: JDevlieghere. Adding a few relevant reviewers :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158010/new/

[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

electriclilies created this revision. Herald added a project: All. electriclilies requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Allow the definition of synthetic formatters in C++, and fix linking problems with the CXXSyntheticChildren