labath accepted this revision.
labath added a reviewer: labath.
labath added a comment.
`__builtin_debugtrap()` indeed works (thanks Jim), but only on clang (no gcc).
Since that is architecture-independent, I think we should use that and just
make the test @skipIfGcc. Apart from that, the test
amccarth marked 3 inline comments as done.
amccarth added a comment.
Thanks for the Linux check Pavel.
I'm running one last check and then I'll submit and keep an eye on the
buildbots for the rest of the day.
Comment at:
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
Windows stuff looks good to me.
http://reviews.llvm.org/D15834
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
amccarth updated this revision to Diff 44264.
amccarth added a comment.
Restored TestBuiltinTrap.py because that's actually for something else.
Changed TestDebugbreak.py to use asm("int3") on non-Windows x86.
I've ordered a Linux box, but I don't currently have one, so I haven't been
able to
amccarth added a comment.
PTAL: I've enhanced the test to do a couple extra checks that
TestBuiltinTrap.py was doing, and I've eliminated that old test.
I believe it should work on Linux as well as Windows, but I'm not set up with a
Linux machine right now. If someone could try this patch on
amccarth updated this revision to Diff 44179.
amccarth added a comment.
Herald added subscribers: srhines, danalbert, tberghammer.
I've rolled bits of TestBuiltinTrap.py into the new test and deleted the old
one.
This still works on Windows. I'm not set up to test it on Linux.
labath added a comment.
I agree that the new test is better than the existing linux one, which can
therefore be removed. If you wish, I can do it after you get this in.
http://reviews.llvm.org/D15834
___
lldb-commits mailing list
labath added a subscriber: labath.
labath added a comment.
Linux tests the same functionality in TestBuiltinTrap.py. Would it make sense
to merge these two tests, given that the only difference is which compiler
intrinsic is used to generate the int3 trap?
http://reviews.llvm.org/D15834
amccarth added a comment.
In http://reviews.llvm.org/D15834#318623, @labath wrote:
> Linux tests the same functionality in TestBuiltinTrap.py. Would it make sense
> to merge these two tests, given that the only difference is which compiler
> intrinsic is used to generate the int3 trap?
Yes,
jingham added a subscriber: jingham.
jingham added a comment.
Shouldn't we just remove the Linux test case in favor of your test case? The
notion of a builtin_trap of some sort or other seems general. And, it looks
like both the Linux port and the Windows port needed to do something to handle
amccarth created this revision.
amccarth added a reviewer: zturner.
amccarth added a subscriber: lldb-commits.
No hurry on the review. This can go in next year. :-)
This required a little rejiggering of ProcessWindowsLive::RefreshStateAfterStop
in order to treat an unexpected breakpoint opcode
zturner added inline comments.
Comment at: source/Plugins/Process/Windows/Live/ProcessWindowsLive.cpp:601-605
@@ -579,5 +600,7 @@
{
+// The thread hit a hard-coded breakpoint like an `int 3` or
`__debugbreak()`.
12 matches
Mail list logo
