This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG764287f1ad69: [lldb] Add support for recognizing swift ast
sections in object files (authored by bulbazord).
Repository:
rG LLVM Github Monorepo
bulbazord added a comment.
It seems like there is consensus for actually implementing this functionality
but that there were some questions about the actual string. I hope everyone
finds my reasoning understandable. If nobody has a strong objection to the
actual string, I will land this tomorro
bulbazord added inline comments.
Comment at: lldb/source/Core/Section.cpp:153
+ case eSectionTypeSwiftModules:
+return "swift-modules";
}
compnerd wrote:
> kastiglione wrote:
> > I wonder if this should be "swiftmodules". I have never seen it spelled
> >
compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.
LGTM with @kastiglione's comments addressed.
Comment at: lldb/source/Core/Section.cpp:153
+ case eSectionTypeSwiftModules:
+return "swift-modules";
}
kastiglione added inline comments.
Comment at: lldb/source/Core/Section.cpp:153
+ case eSectionTypeSwiftModules:
+return "swift-modules";
}
I wonder if this should be "swiftmodules". I have never seen it spelled with a
hyphen.
Repository:
rG LLVM Git
bulbazord created this revision.
bulbazord added reviewers: JDevlieghere, aprantl, fdeazeve, kastiglione,
augusto2112.
Herald added a subscriber: emaste.
Herald added a project: All.
bulbazord requested review of this revision.
Herald added subscribers: lldb-commits, MaskRay.
Herald added a projec
