This revision was automatically updated to reflect the committed changes.
Closed by commit rGa5a2a5a3eca0: [lldb][NFCI] Remove use of ConstString in
StructuredData (authored by bulbazord).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159313/new/
fdeazeve accepted this revision.
fdeazeve added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159313/new/
https://reviews.llvm.org/D159313
bulbazord updated this revision to Diff 556798.
bulbazord added a comment.
Remove unneeded lambda
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159313/new/
https://reviews.llvm.org/D159313
Files:
lldb/include/lldb/Utility/StructuredData.h
bulbazord added inline comments.
Comment at: lldb/source/Utility/StructuredData.cpp:249-251
+ llvm::sort(sorted_entries, [&](const Entry , const Entry ) -> bool {
+return lhs.first < rhs.first;
+ });
Oh I can remove this lambda too -- Let me update.
bulbazord added inline comments.
Comment at: lldb/include/lldb/Utility/StructuredData.h:436
auto array_sp = std::make_shared();
- collection::const_iterator iter;
- for (iter = m_dict.begin(); iter != m_dict.end(); ++iter) {
+ for (auto iter =
bulbazord updated this revision to Diff 556469.
bulbazord marked 7 inline comments as done.
bulbazord added a comment.
Address feedback from @fdeazeve
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159313/new/
https://reviews.llvm.org/D159313
bulbazord marked an inline comment as done.
bulbazord added inline comments.
Comment at: lldb/include/lldb/Utility/StructuredData.h:448
- if (!key.empty()) {
-ConstString key_cs(key);
-collection::const_iterator iter = m_dict.find(key_cs);
fdeazeve added inline comments.
Comment at: lldb/include/lldb/Utility/StructuredData.h:436
auto array_sp = std::make_shared();
- collection::const_iterator iter;
- for (iter = m_dict.begin(); iter != m_dict.end(); ++iter) {
+ for (auto iter =
bulbazord created this revision.
bulbazord added reviewers: JDevlieghere, mib, jingham, fdeazeve.
Herald added a subscriber: mgrang.
Herald added a project: All.
bulbazord requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
The remaining use
