Re: [Lldb-commits] [PATCH] D15978: Prevent infinite recursive loop in AppleObjCTrampolineHandler constructor

2016-01-08 Thread Francis Ricci via lldb-commits
fjricci added a comment. Would you still like me to make the parameter change to InferiorCallMmap before merging? http://reviews.llvm.org/D15978 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D15978: Prevent infinite recursive loop in AppleObjCTrampolineHandler constructor

2016-01-08 Thread Stephane Sezer via lldb-commits
sas closed this revision. sas added a comment. Committed as r257204. http://reviews.llvm.org/D15978 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D15978: Prevent infinite recursive loop in AppleObjCTrampolineHandler constructor

2016-01-08 Thread Jim Ingham via lldb-commits
jingham accepted this revision. jingham added a comment. Great, thanks! http://reviews.llvm.org/D15978 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D15978: Prevent infinite recursive loop in AppleObjCTrampolineHandler constructor

2016-01-07 Thread Jim Ingham via lldb-commits
jingham added a comment. Can you post the backtrace in this case? It seems to me odd that CanJIT -> AllocateMemory needs to construct the AppleObjCRuntime to do its job. I'd rather cut the chain at that point if it makes sense. http://reviews.llvm.org/D15978

Re: [Lldb-commits] [PATCH] D15978: Prevent infinite recursive loop in AppleObjCTrampolineHandler constructor

2016-01-07 Thread Jim Ingham via lldb-commits
jingham added a comment. Cool! For completeness I think it is a good idea to do this to all the functions in InferiorCallPOSIX. For the general InferiorCall one it might be a good idea to add a defaulted (to false) parameter so that if somebody really needs to use it for something that might

Re: [Lldb-commits] [PATCH] D15978: Prevent infinite recursive loop in AppleObjCTrampolineHandler constructor

2016-01-07 Thread Jim Ingham via lldb-commits
jingham added a comment. Ah, right. We're doing that so that we can make sure that an ObjC Exception thrown during the course of expression evaluation doesn't unwind past the frame we are using to call the function. Seems like for low-level stuff like AllocateMemory we should be avoiding all

Re: [Lldb-commits] [PATCH] D15978: Prevent infinite recursive loop in AppleObjCTrampolineHandler constructor

2016-01-07 Thread Jim Ingham via lldb-commits
jingham added a comment. That penultimate sentence would be clearer if I had put the end ")" in the right place - after "recursion" http://reviews.llvm.org/D15978 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D15978: Prevent infinite recursive loop in AppleObjCTrampolineHandler constructor

2016-01-07 Thread Francis Ricci via lldb-commits
fjricci created this revision. fjricci added reviewers: clayborg, jingham. fjricci added subscribers: lldb-commits, sas. When we construct AppleObjCTrampolineHandler, if m_impl_fn_addr is invalid, we call CanJIT(). If the gdb remote process does not support allocating and deallocating memory,

Re: [Lldb-commits] [PATCH] D15978: Prevent infinite recursive loop in AppleObjCTrampolineHandler constructor

2016-01-07 Thread Francis Ricci via lldb-commits
fjricci added a comment. Here's a paste of the end of the backtrace. pastebin.com/3VkF3Biq http://reviews.llvm.org/D15978 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D15978: Prevent infinite recursive loop in AppleObjCTrampolineHandler constructor

2016-01-07 Thread Francis Ricci via lldb-commits
fjricci added a comment. @jingham - your suggestion does avoid the recursion as well, and seems a lot cleaner. http://reviews.llvm.org/D15978 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D15978: Prevent infinite recursive loop in AppleObjCTrampolineHandler constructor

2016-01-07 Thread Francis Ricci via lldb-commits
fjricci updated this revision to Diff 44305. fjricci added a comment. Follow suggestion by @jingham to avoid setting up ObjC runtime for low-level POSIX memory allocations http://reviews.llvm.org/D15978 Files: source/Plugins/Process/Utility/InferiorCallPOSIX.cpp Index: