Re: [Lldb-commits] [PATCH] D15992: Centralize the handling of attach permissions on linux in tests

2016-01-11 Thread Pavel Labath via lldb-commits
labath added a comment. Good idea. I'll do that. http://reviews.llvm.org/D15992 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D15992: Centralize the handling of attach permissions on linux in tests

2016-01-11 Thread Pavel Labath via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL257319: Centralize the handling of attach permissions on linux in tests (authored by labath). Changed prior to commit: http://reviews.llvm.org/D15992?vs=44316=44453#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D15992: Centralize the handling of attach permissions on linux in tests

2016-01-08 Thread Jim Ingham via lldb-commits
jingham added a subscriber: jingham. jingham added a comment. Would you mind adding a note to README-TestSuite saying that you have to call this function if you want to attach to the binary you are building as part of the testsuite. As with all docs it's likely very few will read the note, but

[Lldb-commits] [PATCH] D15992: Centralize the handling of attach permissions on linux in tests

2016-01-08 Thread Pavel Labath via lldb-commits
labath created this revision. labath added a reviewer: clayborg. labath added a subscriber: lldb-commits. On linux we need the process to give us special permissions before we can attach to it. Previously, the code for this was copied into every file that needed it. This moves the code to a