[Lldb-commits] [PATCH] D16703: Fix TestDataFormatterScript for Linux.

2016-01-28 Thread Chaoren Lin via lldb-commits
chaoren created this revision. chaoren added a reviewer: granata.enrico. chaoren added a subscriber: lldb-commits. m_function_name will contain a dummy name for the auto-generated function from the python script on Linux. Check for script name first. http://reviews.llvm.org/D16703 Files:

Re: [Lldb-commits] [PATCH] D16703: Fix TestDataFormatterScript for Linux.

2016-01-28 Thread Chaoren Lin via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL259153: Fix TestDataFormatterScript for Linux. (authored by chaoren). Changed prior to commit: http://reviews.llvm.org/D16703?vs=46330=46340#toc Repository: rL LLVM http://reviews.llvm.org/D16703

Re: [Lldb-commits] [PATCH] D16703: Fix TestDataFormatterScript for Linux.

2016-01-28 Thread Enrico Granata via lldb-commits
granata.enrico added a comment. That seems reasonable, yes. In general, I wish I had done this not via two strings - only one of which gets to be valid in some arbitrary order - but via either two distinct subclasses, or at least via a pair of a string and an enum class specifying the kind.