tberghammer added a comment.
I would prefer a more general solution then the one Pavel proposed because
currently we are adding 2 more options (abi and isa) but in the future we might
need a lot of other stuff as well and adding a new argument for each one will
be problematic (e.g. omit frame p
labath added a comment.
So, the way I would achieve this is to have a way to specify "i want to run the
tests with hard-float", or "I want to use thumb instruction set" when running
dotest.py and then based on this information, set the correct compiler flags
**and** xfail/skip tests. When we do
tberghammer added a comment.
You can pass extra compiler flags to the test suit with the -E option (haven't
tested it). I would suggest to use that option and then xfail based on it
(xfail if extra flags contain -foo).
In long term I would prefer to not add a new option to expectedFailureAll bu
chying added a comment.
In http://reviews.llvm.org/D18481#383718, @zturner wrote:
> Couldn't we have a way to say in the Makefile "never use these flags", then
> the test suite could check the environment and remove them if they are
> present. This woudl allow the test to run.
>
> architecture
zturner added a comment.
I'll still wait and see what Pavel and/or Tamas say, but if we are going to go
this route, I would rather the argument be called `cflags` and now `env_flags`.
Xfailing a test based on an arbitrary environment variable just seems like
something we shouldn't be doing. I
zturner added a comment.
Couldn't we have a way to say in the Makefile "never use these flags", then the
test suite could check the environment and remove them if they are present.
This woudl allow the test to run.
architecture, compiler, etc are things we don't really have control over. If a
chaoren added a comment.
In http://reviews.llvm.org/D18481#383694, @zturner wrote:
> This seems very strange to me. What if someone specifies those flags on the
> command line in the makefile instead of via some environment variables?
I don't think there's anything we can do about that unless
zturner added reviewers: labath, tberghammer.
zturner added a comment.
This seems very strange to me. What if someone specifies those flags on the
command line in the makefile instead of via some environment variables?
It also seems like a very specialized argument that we might use once or twi
chying created this revision.
chying added reviewers: chaoren, zturner.
chying added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer, rengolin, aemerson.
xfail TestCallUserAnonTypedef.test for -mthumb,
TestReturnValue.test_with_python for hard fp,
TestLldbGdbServer.s
