Re: [Lldb-commits] [PATCH] D19772: Detect Python's executable on NetBSD

2016-05-01 Thread Kamil Rytarowski via lldb-commits
krytarowski abandoned this revision. krytarowski added a comment. This change will be merged into http://reviews.llvm.org/D15067 Repository: rL LLVM http://reviews.llvm.org/D19772 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://

Re: [Lldb-commits] [PATCH] D19772: Detect Python's executable on NetBSD

2016-05-01 Thread Pavel Labath via lldb-commits
labath added a comment. In http://reviews.llvm.org/D19772#417954, @krytarowski wrote: > I think I can close this report and http://reviews.llvm.org/D19685, and put > all the standalone CMake code mentioned here and in > http://reviews.llvm.org/D19685 as a patch in http://reviews.llvm.org/D15067

Re: [Lldb-commits] [PATCH] D19772: Detect Python's executable on NetBSD

2016-04-30 Thread Zachary Turner via lldb-commits
Yea, just don't bump the minimum CMake version past 2.8.12 On Sat, Apr 30, 2016 at 6:56 PM Kamil Rytarowski wrote: > krytarowski added a comment. > > Great! I think I will close > > In http://reviews.llvm.org/D19772#417952, @zturner wrote: > > > I'm not sure anyone else uses the standalone build,

Re: [Lldb-commits] [PATCH] D19772: Detect Python's executable on NetBSD

2016-04-30 Thread Zachary Turner via lldb-commits
zturner added a comment. Yea, just don't bump the minimum CMake version past 2.8.12 Repository: rL LLVM http://reviews.llvm.org/D19772 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c

Re: [Lldb-commits] [PATCH] D19772: Detect Python's executable on NetBSD

2016-04-30 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. Great! I think I will close In http://reviews.llvm.org/D19772#417952, @zturner wrote: > I'm not sure anyone else uses the standalone build, so as long as the > changes you're making are confined to LLDBStandalone, it should be fine Thanks! I think I can close thi

Re: [Lldb-commits] [PATCH] D19772: Detect Python's executable on NetBSD

2016-04-30 Thread Zachary Turner via lldb-commits
I'm not sure anyone else uses the standalone build, so as long as the changes you're making are confined to LLDBStandalone, it should be fine On Sat, Apr 30, 2016 at 6:41 PM Kamil Rytarowski wrote: > krytarowski added a comment. > > If the change should go to LLDBStandalone.cmake -- can I just pu

Re: [Lldb-commits] [PATCH] D19772: Detect Python's executable on NetBSD

2016-04-30 Thread Zachary Turner via lldb-commits
zturner added a comment. I'm not sure anyone else uses the standalone build, so as long as the changes you're making are confined to LLDBStandalone, it should be fine Repository: rL LLVM http://reviews.llvm.org/D19772 ___ lldb-commits mailing lis

Re: [Lldb-commits] [PATCH] D19772: Detect Python's executable on NetBSD

2016-04-30 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. If the change should go to LLDBStandalone.cmake -- can I just put there in one go all the bits for standalone builds? --- cmake/modules/LLDBStandalone.cmake.orig 2016-04-27 00:55:49.0 + +++ cmake/modules/LLDBStandalone.cmake @@ -2,61 +2,82 @@

Re: [Lldb-commits] [PATCH] D19772: Detect Python's executable on NetBSD

2016-04-30 Thread Zachary Turner via lldb-commits
zturner added a comment. Ahh makes sense. In that case maybe this line should go in LLDBStandalone.cmake? Repository: rL LLVM http://reviews.llvm.org/D19772 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

Re: [Lldb-commits] [PATCH] D19772: Detect Python's executable on NetBSD

2016-04-30 Thread Zachary Turner via lldb-commits
Ahh makes sense. In that case maybe this line should go in LLDBStandalone.cmake? On Sat, Apr 30, 2016 at 6:15 PM Kamil Rytarowski wrote: > krytarowski added a comment. > > I'm using standalone build, it may be the reason why this value isn't > inherited. > > > Repository: > rL LLVM > > http://r

Re: [Lldb-commits] [PATCH] D19772: Detect Python's executable on NetBSD

2016-04-30 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. I'm using standalone build, it may be the reason why this value isn't inherited. Repository: rL LLVM http://reviews.llvm.org/D19772 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-b

Re: [Lldb-commits] [PATCH] D19772: Detect Python's executable on NetBSD

2016-04-30 Thread Zachary Turner via lldb-commits
zturner added inline comments. Comment at: scripts/CMakeLists.txt:12 @@ -11,1 +11,3 @@ +include(FindPythonInterp) + Is the problem that `PYTHON_EXECUTABLE` is not set? I see a call to `include(FindPythonInterp)` in `llvm/CMakeLists.txt`. Is the value getting

Re: [Lldb-commits] [PATCH] D19772: Detect Python's executable on NetBSD

2016-04-30 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. In http://reviews.llvm.org/D19772#417922, @zturner wrote: > Don't we already call FindPythonInterp from somewhere else in the LLDB's > CMake files? $ git grep FindPythonInterp cmake/modules/LLDBStandalone.cmake:include(FindPythonInterp) scripts/Python/m

Re: [Lldb-commits] [PATCH] D19772: Detect Python's executable on NetBSD

2016-04-30 Thread Zachary Turner via lldb-commits
Don't we already call FindPythonInterp from somewhere else in the LLDB's CMake files? On Sat, Apr 30, 2016 at 5:17 PM Kamil Rytarowski wrote: > krytarowski created this revision. > krytarowski added reviewers: emaste, labath, zturner. > krytarowski added subscribers: lldb-commits, joerg. > kryta

Re: [Lldb-commits] [PATCH] D19772: Detect Python's executable on NetBSD

2016-04-30 Thread Zachary Turner via lldb-commits
zturner added a subscriber: zturner. zturner added a comment. Don't we already call FindPythonInterp from somewhere else in the LLDB's CMake files? Repository: rL LLVM http://reviews.llvm.org/D19772 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D19772: Detect Python's executable on NetBSD

2016-04-30 Thread Kamil Rytarowski via lldb-commits
krytarowski created this revision. krytarowski added reviewers: emaste, labath, zturner. krytarowski added subscribers: lldb-commits, joerg. krytarowski set the repository for this revision to rL LLVM. NetBSD ships with pkgsrc that installs versioned Python executables with suffix, like: python2.