Re: [Lldb-commits] [PATCH] D21757: Fix lldb-mi disable/enable breakpoints commands

2016-07-14 Thread Ilia K via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL275381: Fix -break-enable/-break-disable commands (MI) (authored by ki.stfu). Changed prior to commit: http://reviews.llvm.org/D21757?vs=63928=63932#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D21757: Fix lldb-mi disable/enable breakpoints commands

2016-07-14 Thread Ilia K via lldb-commits
ki.stfu updated this revision to Diff 63928. ki.stfu added a comment. add checks for =breakpoint-modified http://reviews.llvm.org/D21757 Files: packages/Python/lldbsuite/test/tools/lldb-mi/breakpoint/TestMiBreak.py tools/lldb-mi/MICmdCmdBreak.cpp Index: tools/lldb-mi/MICmdCmdBreak.cpp

Re: [Lldb-commits] [PATCH] D21757: Fix lldb-mi disable/enable breakpoints commands

2016-07-14 Thread Ilia K via lldb-commits
ki.stfu accepted this revision. ki.stfu added a comment. @faxue, thank you for your patch! The fixes look good, but if you don't mind I gonna improve your tests. After that I'll commit this patch. Repository: rL LLVM http://reviews.llvm.org/D21757

Re: [Lldb-commits] [PATCH] D21757: Fix lldb-mi disable/enable breakpoints commands

2016-07-13 Thread Ilia K via lldb-commits
ki.stfu added a comment. Hi Chuck! Sorry for delay, didn't see this CL. I'll check it tomorrow, so pls wait one more day. Repository: rL LLVM http://reviews.llvm.org/D21757 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D21757: Fix lldb-mi disable/enable breakpoints commands

2016-07-12 Thread Chuck Ries via lldb-commits
ChuckR added a subscriber: ki.stfu. ChuckR added a comment. @abidh @ki.stfu Do you have any feedback? We would like to check this in and I want to get more sign off then just me. Repository: rL LLVM http://reviews.llvm.org/D21757 ___

[Lldb-commits] [PATCH] D21757: Fix lldb-mi disable/enable breakpoints commands

2016-06-27 Thread Fangliang Xue via lldb-commits
faxue created this revision. faxue added reviewers: abidh, ChuckR, jacdavis. faxue added a subscriber: lldb-commits. faxue set the repository for this revision to rL LLVM. 1) Make the enable breakpoint command actually enable 2) Remove unnecessary output from disable/enable command which isn't