This revision was automatically updated to reflect the committed changes.
Closed by commit rL314045: Implement trampoline step-through for Windows-x86.
(authored by sas).
Repository:
rL LLVM
https://reviews.llvm.org/D22231
Files:
lldb/trunk/source/Plugins/DynamicLoader/Windows-DYLD/Dynamic
sas updated this revision to Diff 116440.
sas added a comment.
Rebase + clang-format.
https://reviews.llvm.org/D22231
Files:
source/Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWindowsDYLD.cpp
Index: source/Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWindowsDYLD.cpp
=
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
I seem not to close the formal loop on these reviews...
https://reviews.llvm.org/D22231
___
lldb-commits mailing list
lldb-commits@lists.llvm.o
clayborg resigned from this revision.
clayborg removed a reviewer: clayborg.
clayborg added a comment.
Jim Ingham should OK any changes. If Jim is happy, then I am OK.
http://reviews.llvm.org/D22231
___
lldb-commits mailing list
lldb-commits@lists.l
Sounds good. I can make a separate patch to make all the constructors
public if you think that's better. See http://reviews.llvm.org/D22230
for a patch that makes one of the constructors public.
Is this patch good to go in its current form then?
On Mon, Jul 11, 2016 at 12:21 PM, Jim Ingham wrote
sas added a subscriber: sas.
sas added a comment.
Sounds good. I can make a separate patch to make all the constructors
public if you think that's better. See http://reviews.llvm.org/D22230
for a patch that makes one of the constructors public.
Is this patch good to go in its current form then?
jingham added a comment.
Yes, that's sad. It needs to be done that way because the plan that organizes
stepping "through" and provides a safety backstop if the step through runs away
needs to push the sub-plans after it has been pushed. We could move all the
stuff in the ThreadPlanStepThrough
sas requested a review of this revision.
sas added a comment.
@jingham, it looks like the `GetStepThroughTrampolinePlan` functions do not
queue the thread plan themselves. See
`DynamicLoaderPOSIXDYLD::GetStepThroughTrampolinePlan` for instance that just
does `new ThreadPlanRunToAddress(...)`.
jingham added a subscriber: jingham.
jingham requested changes to this revision.
jingham added a reviewer: jingham.
jingham added a comment.
This revision now requires changes to proceed.
Can't you just call "thread->QueueThreadPlanForStepSingleInstruction"? For the
most part, it doesn't make se
zturner added a comment.
Excited to see this working. I will look at the patch in detail later, do you
think you could make a test for it?
http://reviews.llvm.org/D22231
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.o
sas created this revision.
sas added reviewers: clayborg, zturner.
sas added a subscriber: lldb-commits.
This is required to be able to step through calls to external functions
that are not properly marked with __declspec(dllimport). When a call
like this is emitted, the linker will inject a tramp
11 matches
Mail list logo
