malaperle added a comment.
Would it be possible to apply this fix to the release_39 branch?
Repository:
rL LLVM
https://reviews.llvm.org/D22902
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277117: Fix -break-insert not working when using absolute
paths (MI) (authored by ki.stfu).
Changed prior to commit:
https://reviews.llvm.org/D22902?vs=66055=66079#toc
Repository:
rL LLVM
malaperle added a comment.
Thanks! Newcomer silly question: now that the change is accepted, is there any
action required on my end?
https://reviews.llvm.org/D22902
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
There should be a way to specify the lldb-mi binary. If there isn't feel free
to add one to the test suite.
https://reviews.llvm.org/D22902
malaperle added a comment.
In https://reviews.llvm.org/D22902#500174, @malaperle wrote:
> This failed for me because lldb is a symlink to lldb-4.0.0 and lldb-4.0.0-mi
> doesn't exist. I'm not sure if there either a way to not make it resolve the
> symlink or if the script should be changed.
malaperle updated this revision to Diff 66055.
malaperle added a comment.
The test actually already existed but now it passed.
https://reviews.llvm.org/D22902
Files:
packages/Python/lldbsuite/test/tools/lldb-mi/breakpoint/TestMiBreak.py
tools/lldb-mi/MICmdArgValString.cpp
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Add a test and this is good to go.
https://reviews.llvm.org/D22902
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ki.stfu added a comment.
Could you add a test case for this in
packages/Python/lldbsuite/test/tools/lldb-mi/breakpoint/TestMiBreak.py?
https://reviews.llvm.org/D22902
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
