Re: [Lldb-commits] [PATCH] D24079: Always rely on CFI unwind info for linux vdso

2016-08-31 Thread Pavel Labath via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL280264: Always rely on CFI unwind info for linux vdso (authored by labath). Changed prior to commit: https://reviews.llvm.org/D24079?vs=69857=69883#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D24079: Always rely on CFI unwind info for linux vdso

2016-08-31 Thread Pavel Labath via lldb-commits
labath added inline comments. Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:13-14 @@ +12,4 @@ + +// Project includes +#include "AuxVector.h" + tberghammer wrote: > Why do we need this? I'm not adding anything. I just took the

Re: [Lldb-commits] [PATCH] D24079: Always rely on CFI unwind info for linux vdso

2016-08-31 Thread Tamas Berghammer via lldb-commits
tberghammer accepted this revision. tberghammer added a comment. This revision is now accepted and ready to land. Looks good Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:13-14 @@ +12,4 @@ + +// Project includes +#include "AuxVector.h" +

[Lldb-commits] [PATCH] D24079: Always rely on CFI unwind info for linux vdso

2016-08-31 Thread Pavel Labath via lldb-commits
labath created this revision. labath added a reviewer: tberghammer. labath added a subscriber: lldb-commits. Herald added subscribers: danalbert, tberghammer. The vdso is full of hand-written assembly which the instruction emulator has a hard time understanding. Luckily, the kernel already