Re: [Lldb-commits] [PATCH] D24202: [lldb-mi] Fix parsing expressions to evaluate with spaces and optional args

2016-09-12 Thread Ed Munoz via lldb-commits
edmunoz added a comment. In https://reviews.llvm.org/D24202#539629, @ki.stfu wrote: > lgtm > > @edmunoz, good job. Thank you! Would you like me to commit? Thanks! Yes, go ahead. Repository: rL LLVM https://reviews.llvm.org/D24202 ___

Re: [Lldb-commits] [PATCH] D24202: [lldb-mi] Fix parsing expressions to evaluate with spaces and optional args

2016-09-12 Thread Ilia K via lldb-commits
ki.stfu accepted this revision. ki.stfu added a comment. This revision is now accepted and ready to land. lgtm @edmunoz, good job. Thank you! Would you like me to commit? Repository: rL LLVM https://reviews.llvm.org/D24202 ___ lldb-commits

Re: [Lldb-commits] [PATCH] D24202: [lldb-mi] Fix parsing expressions to evaluate with spaces and optional args

2016-09-02 Thread Ed Munoz via lldb-commits
edmunoz added inline comments. Comment at: tools/lldb-mi/MICmdArgValOptionLong.cpp:190 @@ -189,10 +189,3 @@ { -CMIUtilString::VecString_t vecOptions; -MIuint nOptionsPresent = 0; -if ((m_eExpectingOptionType != eArgValType_StringQuoted) && (m_eExpectingOptionType !=

[Lldb-commits] [PATCH] D24202: [lldb-mi] Fix parsing expressions to evaluate with spaces and optional args

2016-09-02 Thread Ed Munoz via lldb-commits
edmunoz created this revision. edmunoz added a reviewer: ki.stfu. edmunoz added a subscriber: lldb-commits. edmunoz set the repository for this revision to rL LLVM. edmunoz added a project: LLDB. Herald added a subscriber: ki.stfu. When extracting options for long options (starting with "--"),