ki.stfu added a comment.
lgtm
Repository:
rL LLVM
https://reviews.llvm.org/D24711
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL291104: [lldb-mi] Fix implementation for a few mi commands
(authored by abidh).
Changed prior to commit:
https://reviews.llvm.org/D24711?vs=82654=83225#toc
Repository:
rL LLVM
abidh added a comment.
> What do I do next? Could you help me commit and push this? since I don't have
> write access.
I will commit it for you.
https://reviews.llvm.org/D24711
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
aetf marked 2 inline comments as done.
aetf added a comment.
What do I do next? Could you help me commit and push this? since I don't have
write access.
Comment at: packages/Python/lldbsuite/test/tools/lldb-mi/main.cpp:22
{
-int a = 10;
+int a = 10;
+
abidh accepted this revision.
abidh added a comment.
Looks good.
Comment at: packages/Python/lldbsuite/test/tools/lldb-mi/main.cpp:22
{
-int a = 10;
+int a = 10;
+
This declaration looks redundant.
Comment at:
aetf added a comment.
Hi, sorry for the long delay. It has been a busy semester.
Added unit tests are
- `MiGdbSetShowTestCase.test_lldbmi_gdb_set_disassembly_flavor` for disassembly
flavor settings. Note this one doesn't pass currently due to
https://llvm.org/bugs/show_bug.cgi?id=31485
-
aetf updated this revision to Diff 82654.
aetf marked an inline comment as done.
aetf added a comment.
Add unit tests, add error checking for SetInternalVariable
https://reviews.llvm.org/D24711
Files:
packages/Python/lldbsuite/test/tools/lldb-mi/TestMiEnvironmentCd.py
abidh added a comment.
Changes looks mostly Ok to me apart from some comments. Please address them and
add testcases as mentioned by ilia. Also try to do one review for one fix. This
review is for 3 fixes. When the changes are approved, please commit them in 3
separate commits (one per fix).
ki.stfu added a comment.
yes
Repository:
rL LLVM
https://reviews.llvm.org/D24711
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
aetf created this revision.
aetf added a reviewer: ki.stfu.
aetf added a subscriber: lldb-commits.
Herald added a subscriber: ki.stfu.
Some of the mi commands implemented in lldb-mi are incomplete/not confirming to
the spec.
- `gdb-show` and `gdb-set` doesn't support getting/setting
aetf added a comment.
Okay, tests should go to `packages/Python/lldbsuite/test/tools/lldb-mi`, right?
I need to get familiar with them first.
Repository:
rL LLVM
https://reviews.llvm.org/D24711
___
lldb-commits mailing list
ki.stfu requested changes to this revision.
ki.stfu added a comment.
This revision now requires changes to proceed.
Hi! Please add tests for commands that you fixed. I'll take a look later this
week.
Repository:
rL LLVM
https://reviews.llvm.org/D24711
12 matches
Mail list logo
