[Lldb-commits] [PATCH] D25488: Fix test suite lookup path for LLDB.h

2016-10-13 Thread Todd Fiala via lldb-commits
tfiala added a comment. (Retro) LGTM. Repository: rL LLVM https://reviews.llvm.org/D25488 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D25488: Fix test suite lookup path for LLDB.h

2016-10-12 Thread Chris Bieneman via lldb-commits
beanz added a comment. @labath I think having them running is useful. At the moment that is probably the only Darwin bot building LLDB using CMake. https://reviews.llvm.org/D25488 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D25488: Fix test suite lookup path for LLDB.h

2016-10-12 Thread Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL284043: Fix test suite lookup path for LLDB.h (authored by cbieneman). Changed prior to commit: https://reviews.llvm.org/D25488?vs=74294=74431#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D25488: Fix test suite lookup path for LLDB.h

2016-10-12 Thread Pavel Labath via lldb-commits
labath added a comment. Our darwin buildbot is also running the local test suite with cmake: http://lab.llvm.org:8011/builders/lldb-x86_64-darwin-13.4, look under build step "test9 local test". We've been considering turning these tests off as we don't have bandwidth to monitor and fix them,

[Lldb-commits] [PATCH] D25488: Fix test suite lookup path for LLDB.h

2016-10-11 Thread Chris Bieneman via lldb-commits
beanz created this revision. beanz added reviewers: tfiala, zturner. beanz added a subscriber: lldb-commits. When running on Darwin, the test suite assumes a specific directory structure for the build directory. This works for the Xcode project builds, but fails for CMake builds regardless of