This revision was automatically updated to reflect the committed changes.
Closed by commit rL292937: FreeBSD ARM support for software single step
(authored by emaste).
Changed prior to commit:
https://reviews.llvm.org/D25756?vs=79987&id=85581#toc
Repository:
rL LLVM
https://reviews.llvm.org
dmikulin added a comment.
@emaste , any chance to get this committed soon?
Repository:
rL LLVM
https://reviews.llvm.org/D25756
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dmikulin updated this revision to Diff 79987.
dmikulin added a comment.
Addressed review comments.
Haven't had a chance to re-test it on an arm board.
Repository:
rL LLVM
https://reviews.llvm.org/D25756
Files:
source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp
source/Plugins/Process/Fre
emaste added inline comments.
Comment at: source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp:551-557
+} else {
+ static const uint8_t g_arm_breakpoint_opcode[] = {0xFE,0xDE,0xFF,0xE7};
+ size_t trap_opcode_size = sizeof(g_arm_breakpoint_opcode);
+ assert(bp_si
krytarowski added a comment.
I just scrolled the discussion so it's not really started. Thanks.
My plan is to work on ptrace(2) for about a month.
Then I will take the FreeBSD code as it is and port to NetBSD trying to make it
functional. This is difficult part as there is everywhere OS specifi
krytarowski added a comment.
@emaste What's the status of remote debugging on FreeBSD?
Repository:
rL LLVM
https://reviews.llvm.org/D25756
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/ll
krytarowski added a comment.
NetBSD is still focused on amd64-only port.
I start a funded project November 1st on getting x86 process plugin to work.
More details here:
http://blog.netbsd.org/tnf/entry/funded_contract_2016_2017
Estimated time is 4 months full-time.
However there every help is
emaste added a subscriber: krytarowski.
emaste added a comment.
On a quick look this seems OK. I'll try to test/review in detail.
In https://reviews.llvm.org/D25756#576642, @dmikulin wrote:
> Thanks Pavel! I'll start working on it. Do you know when lldb-server Linux
> changes were committed? I
dmikulin marked an inline comment as done.
dmikulin added a comment.
Thanks Pavel! I'll start working on it. Do you know when lldb-server Linux
changes were committed? I want to use those patches as a template, but it's
hard to locate them digging through thousands of commit log entries...
Ed,
labath added a comment.
I don't know of any good source of documentation for this, but I am willing to
answer any questions you might have about this. Basically, the idea of
lldb-server is that you use the same code path for remote debugging as you to
for local. So all the debugging is done in
dmikulin added a comment.
I'm not familiar enough with the code yet to pick up the work on moving FreeBSD
to lldb-server. Any pointers to revision numbers, internal discussions, etc,
related to the Linux lldb-server switch? Also, if there's any unfinished
FreeBSD work, it would help me get star
emaste added a comment.
On a quick look this seems OK. I'll try to test/review in detail.
Comment at: source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp:925
+
+ // eRegisterKindDWARF -> RegsiterValue
+ std::unordered_map m_register_values;
typo here
Reposito
emaste added a comment.
In https://reviews.llvm.org/D25756#574258, @labath wrote:
> No, I'm saying someone *should*. :P
>
> Ed looked into that at some point but, I don't think get got too far with it.
> Adding @emaste, who should probably review this.
Yes, it needs to be done. Maybe now that
labath added a reviewer: emaste.
labath added a comment.
No, I'm saying someone *should*. :P
Ed looked into that at some point but, I don't think get got too far with it.
Adding @emaste, who should probably review this.
Repository:
rL LLVM
https://reviews.llvm.org/D25756
dmikulin added a comment.
Are you saying someone is working on switching FreeBSD to lldb-server
debugging? Can I get my hands on this patch?
Repository:
rL LLVM
https://reviews.llvm.org/D25756
___
lldb-commits mailing list
lldb-commits@lists.llv
labath added a comment.
I'd love to see freebsd switch to lldb-server based debugging. Then we could
make sure this code is actually reused instead of copied around (e.g. we are
right now preparing a patch to improve this, which you could have gotten for
free if the code was shared).
Reposit
dmikulin updated this revision to Diff 75090.
dmikulin added a comment.
Fixed indentation.
Repository:
rL LLVM
https://reviews.llvm.org/D25756
Files:
source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp
source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp
source/Plugins/Process/FreeBSD/Pro
dmikulin created this revision.
dmikulin added a subscriber: lldb-commits.
dmikulin set the repository for this revision to rL LLVM.
dmikulin added a project: LLDB.
Herald added subscribers: emaste, rengolin, aemerson.
Implementation of software single step for FreeBSD on ARM.
The code is largely
18 matches
Mail list logo
