[Lldb-commits] [PATCH] D26300: ELF core: Adding parsing of the floating-point and SSE registers on x86 32/64 bit elf core files

2016-11-20 Thread Dimitar Vlahovski via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL287506: ELF core: Adding parsing of the floating-point and SSE registers on x86 32/64… (authored by dvlahovski). Changed prior to commit: https://reviews.llvm.org/D26300?vs=77626&id=78667#toc Repositor

[Lldb-commits] [PATCH] D26300: ELF core: Adding parsing of the floating-point and SSE registers on x86 32/64 bit elf core files

2016-11-14 Thread Ed Maste via lldb-commits
emaste added a comment. I applied this change on top of my WIP https://reviews.llvm.org/D26617 (which adds a FreeBSD core test). LLDB builds and my new test passes, so no objections from me. Once it's in I'll see about porting the new SSE test to FreeBSD too. https://reviews.llvm.org/D26300

[Lldb-commits] [PATCH] D26300: ELF core: Adding parsing of the floating-point and SSE registers on x86 32/64 bit elf core files

2016-11-11 Thread Dimitar Vlahovski via lldb-commits
dvlahovski updated this revision to Diff 77626. dvlahovski marked an inline comment as done. dvlahovski added a comment. Use unique_ptr instead of shared_ptr https://reviews.llvm.org/D26300 Files: packages/Python/lldbsuite/test/functionalities/postmortem/linux-core/TestLinuxCore.py packag

[Lldb-commits] [PATCH] D26300: ELF core: Adding parsing of the floating-point and SSE registers on x86 32/64 bit elf core files

2016-11-10 Thread Pavel Labath via lldb-commits
labath added a comment. Looks great. Ed, do you want to give this a try run? Comment at: packages/Python/lldbsuite/test/functionalities/postmortem/linux-core/TestLinuxCore.py:113 +self.assertTrue(target, VALID_TARGET) +process = target.LoadCore("fpr_sse_x86_64.

[Lldb-commits] [PATCH] D26300: ELF core: Adding parsing of the floating-point and SSE registers on x86 32/64 bit elf core files

2016-11-10 Thread Dimitar Vlahovski via lldb-commits
dvlahovski updated this revision to Diff 77477. dvlahovski added a comment. Generated the core files with make-core.sh https://reviews.llvm.org/D26300 Files: packages/Python/lldbsuite/test/functionalities/postmortem/linux-core/TestLinuxCore.py packages/Python/lldbsuite/test/functionalitie

[Lldb-commits] [PATCH] D26300: ELF core: Adding parsing of the floating-point and SSE registers on x86 32/64 bit elf core files

2016-11-10 Thread Dimitar Vlahovski via lldb-commits
dvlahovski added a comment. I will generate the core files with the `make-core.sh` script and update the revision today or tomorrow. Comment at: packages/Python/lldbsuite/test/functionalities/postmortem/linux-core/TestLinuxCore.py:107 +@skipIf(oslist=['windows']) +

[Lldb-commits] [PATCH] D26300: ELF core: Adding parsing of the floating-point and SSE registers on x86 32/64 bit elf core files

2016-11-07 Thread Pavel Labath via lldb-commits
labath added a comment. I've renamed to folder into elf-core and put "linux" into the individual file names. I did not rename `TestLinuxCore.py` as I am still not sure what to do about it -- if we end up having a lot of these tests, we may want a separate `TestFreeBSDCore.py`, with the common c

[Lldb-commits] [PATCH] D26300: ELF core: Adding parsing of the floating-point and SSE registers on x86 32/64 bit elf core files

2016-11-05 Thread Pavel Labath via lldb-commits
labath added a comment. In https://reviews.llvm.org/D26300#587333, @emaste wrote: > Good point. https://reviews.llvm.org/D26315 has the change to add FreeBSD > support to make-core.sh -- just avoiding /bin/bash, and the core file handler > check. Great. I am glad the `_start` thingy works the

[Lldb-commits] [PATCH] D26300: ELF core: Adding parsing of the floating-point and SSE registers on x86 32/64 bit elf core files

2016-11-04 Thread Ed Maste via lldb-commits
emaste added a comment. Good point. https://reviews.llvm.org/D26315 has the change to add FreeBSD support to make-core.sh -- just avoiding /bin/bash, and the core file handler check. I think we should be able to rename this directory to elf-core, and rename the individual cores to e.g. linux-i

[Lldb-commits] [PATCH] D26300: ELF core: Adding parsing of the floating-point and SSE registers on x86 32/64 bit elf core files

2016-11-04 Thread Pavel Labath via lldb-commits
labath added a comment. I was very successful in creating tiny core files by avoiding linking with the standard library (you don't really need a full libc to crash :P ). I think this file should use the same approach as well (see the other core files in this directory, and the make-core.sh scrip

[Lldb-commits] [PATCH] D26300: ELF core: Adding parsing of the floating-point and SSE registers on x86 32/64 bit elf core files

2016-11-04 Thread Ed Maste via lldb-commits
emaste added a comment. We need to make sure this does not regress FreeBSD core handling -- I will test as soon as I can, and add FXSAVE parsing for FreeBSD. I'll use fpr_sse.cpp to generate FreeBSD core files as well (although note that we get ~2.5MB cores with default configuration, so tweaki

[Lldb-commits] [PATCH] D26300: ELF core: Adding parsing of the floating-point and SSE registers on x86 32/64 bit elf core files

2016-11-04 Thread Dimitar Vlahovski via lldb-commits
dvlahovski created this revision. dvlahovski added a reviewer: labath. dvlahovski added a subscriber: lldb-commits. The floating-point and SSE registers could be present in the elf-core file in the note NT_FPREGSET for 64 bit ones, and in the note NT_PRXFPREG for 32 bit ones. The entire note is a