[Lldb-commits] [PATCH] D27223: Expression evaluation for overloaded C functions (redux)

This revision was automatically updated to reflect the committed changes. Closed by commit rL290117: Expression evaluation for overloaded C functions (redux) (authored by ldrumm). Changed prior to commit: https://reviews.llvm.org/D27223?vs=81753=81967#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D27223: Expression evaluation for overloaded C functions (redux)

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. https://reviews.llvm.org/D27223 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D27223: Expression evaluation for overloaded C functions (redux)

ldrumm added inline comments. Comment at: include/lldb/Core/FastDemangle.h:22 +char * +FastDemangle(const char *mangled_name, size_t mangled_name_length, + std::function primitive_type_hook = nullptr); alexshap wrote: > some

[Lldb-commits] [PATCH] D27223: Expression evaluation for overloaded C functions (redux)

ldrumm updated this revision to Diff 81753. ldrumm marked 6 inline comments as done. ldrumm added a comment. updated to use StringRef-based parser rather than char pointers https://reviews.llvm.org/D27223 Files: include/lldb/Core/FastDemangle.h

[Lldb-commits] [PATCH] D27223: Expression evaluation for overloaded C functions (redux)

alexshap added inline comments. Comment at: include/lldb/Core/FastDemangle.h:22 +char * +FastDemangle(const char *mangled_name, size_t mangled_name_length, + std::function primitive_type_hook = nullptr); some thoughts: (also i