[Lldb-commits] [PATCH] D29427: Move some classes from Core -> Utility

2017-02-01 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. I meant the code in source/Host, but somehow missed the change to Host/macosx/Symbols.cpp on the first pass, so you probably did. https://reviews.llvm.org/D29427 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D29427: Move some classes from Core -> Utility

2017-02-01 Thread Zachary Turner via Phabricator via lldb-commits
zturner added a comment. I didn't do everything needed to get Utility to be standalone if that's what you mean. Some things are trickier than others, so I wanted to isolate this CL to strictly mechanical code move. What Host code were you referring to? BTW, I'll probably submit this tomorrow

[Lldb-commits] [PATCH] D29427: Move some classes from Core -> Utility

2017-02-01 Thread Jim Ingham via Phabricator via lldb-commits
jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. This looks fine to me. Just check it on in and we'll fix the project files after the fact. BTW, did you scrub the Host code and do the mutatis mutandis on them, or will we have to do that

Re: [Lldb-commits] [PATCH] D29427: Move some classes from Core -> Utility

2017-02-01 Thread Jason Molenda via lldb-commits
You need some break;s. -const char *lldb_private::GetVoteAsCString(Vote vote) { - switch (vote) { - case eVoteNo: -return "no"; - case eVoteNoOpinion: -return "no opinion"; - case eVoteYes: -return "yes"; - } - return "invalid"; -} +template <> struct format_provider { +