[Lldb-commits] [PATCH] D30024: [lldb] Add support for "external" reports in ThreadSanitizer LLDB plugin

2017-02-16 Thread Kuba (Brecka) Mracek via Phabricator via lldb-commits
kubamracek added inline comments. Comment at: source/Plugins/InstrumentationRuntime/ThreadSanitizer/ThreadSanitizerRuntime.cpp:89 + +void *dlsym(void* handle, const char* symbol); +int (*ptr__tsan_get_report_loc_object_type)(void *report, unsigned long idx, const

[Lldb-commits] [PATCH] D30024: [lldb] Add support for "external" reports in ThreadSanitizer LLDB plugin

2017-02-16 Thread Kuba (Brecka) Mracek via Phabricator via lldb-commits
kubamracek added inline comments. Comment at: source/Plugins/InstrumentationRuntime/ThreadSanitizer/ThreadSanitizerRuntime.cpp:89 + +void *dlsym(void* handle, const char* symbol); +int (*ptr__tsan_get_report_loc_object_type)(void *report, unsigned long idx, const

[Lldb-commits] [PATCH] D30024: [lldb] Add support for "external" reports in ThreadSanitizer LLDB plugin

2017-02-16 Thread Greg Clayton via Phabricator via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. Comment at: source/Plugins/InstrumentationRuntime/ThreadSanitizer/ThreadSanitizerRuntime.cpp:89 + +void *dlsym(void* handle, const char* symbol); +