[Lldb-commits] [PATCH] D30926: Fix MSVC signed/unsigned conversion and size_t conversion warnings in LLDB

2017-03-17 Thread Zachary Turner via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL298099: Fix some signed/unsigned comparison warnings. (authored by zturner). Changed prior to commit: https://reviews.llvm.org/D30926?vs=91670=92156#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D30926: Fix MSVC signed/unsigned conversion and size_t conversion warnings in LLDB

2017-03-15 Thread Hugh Bellamy via Phabricator via lldb-commits
hughbe edited reviewers, added: zturner; removed: jingham, hughbe. hughbe added a comment. This revision now requires review to proceed. As per discussion on lists https://reviews.llvm.org/D30926 ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] D30926: Fix MSVC signed/unsigned conversion and size_t conversion warnings in LLDB

2017-03-13 Thread Zachary Turner via lldb-commits
Lgtm, no need to request a review for these kind of trivial warning fixes On Mon, Mar 13, 2017 at 9:11 PM Hugh Bellamy via Phabricator via lldb-commits wrote: > hughbe updated this revision to Diff 91670. > hughbe added a comment. > > Fix file names > > >

[Lldb-commits] [PATCH] D30926: Fix MSVC signed/unsigned conversion and size_t conversion warnings in LLDB

2017-03-13 Thread Hugh Bellamy via Phabricator via lldb-commits
hughbe updated this revision to Diff 91670. hughbe added a comment. Fix file names https://reviews.llvm.org/D30926 Files: source/Core/FormatEntity.cpp Index: source/Core/FormatEntity.cpp === --- source/Core/FormatEntity.cpp

[Lldb-commits] [PATCH] D30926: Fix MSVC signed/unsigned conversion and size_t conversion warnings in LLDB

2017-03-13 Thread Hugh Bellamy via Phabricator via lldb-commits
hughbe created this revision. I've been porting swift-lldb to Windows/MSVC, and encountered some size_t/unsigned implicit conversion warnings. I sent a PR (https://github.com/apple/swift-lldb/pull/161) and @jimingham suggested I push some of them here. Repository: rL LLVM