sas added a comment.
In https://reviews.llvm.org/D31086#705159, @labath wrote:
> In https://reviews.llvm.org/D31086#704518, @sas wrote:
>
> > The second behavioral change seems good but the first thing you described
> > is a bit odd. Creating folders with 770 does not seem like a common
> > beh
labath added a comment.
In https://reviews.llvm.org/D31086#704518, @sas wrote:
> The second behavioral change seems good but the first thing you described is
> a bit odd. Creating folders with 770 does not seem like a common behavior,
> and 700 or 755 is usually more standard.
Don't forget th
This revision was automatically updated to reflect the committed changes.
Closed by commit rL298203: Remove FileSystem::MakeDirectory. (authored by
zturner).
Changed prior to commit:
https://reviews.llvm.org/D31086?vs=92162&id=92259#toc
Repository:
rL LLVM
https://reviews.llvm.org/D31086
F
sas accepted this revision.
sas added a comment.
This revision is now accepted and ready to land.
The second behavioral change seems good but the first thing you described is a
bit odd. Creating folders with 770 does not seem like a common behavior, and
700 or 755 is usually more standard.
Eith
labath added a comment.
In https://reviews.llvm.org/D31086#704122, @zturner wrote:
> That one is calling a file static function `MakeDirectory`, not
> `FileSystem::MakeDirectory`, and the implementation of that function already
> calls `llvm::sys::fs::create_directories()` to create the whole t
zturner added a comment.
That one is calling a file static function `MakeDirectory`, not
`FileSystem::MakeDirectory`, and the implementation of that function already
calls `llvm::sys::fs::create_directories()` to create the whole tree, so it
should be fine.
https://reviews.llvm.org/D31086
labath added a comment.
I think you missed one occurence in ModuleCache.cpp. This one creates a full
directory structure, so you will probably need recursion there (unlike in the
rest of these cases, which seem fine). Also unlike the rest of these cases,
that one is actually covered by a unit t
zturner created this revision.
Use the LLVM function instead.
There are two subtle behavioral changes here which I want to make clear so
someone can determine whether this matters on their platform.
1. Previously all LLDB callers were passing `eFilePermissionsDirectoryDefault`
which is equal t
