This revision was automatically updated to reflect the committed changes.
Closed by commit rL298465: Delete the remainder of platform specific code in
FileSpec. (authored by zturner).
Changed prior to commit:
https://reviews.llvm.org/D31129?vs=92373&id=92577#toc
Repository:
rL LLVM
https://
eugene accepted this revision.
eugene added a comment.
This revision is now accepted and ready to land.
I like how much code you deleted.
https://reviews.llvm.org/D31129
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org
labath added a comment.
In https://reviews.llvm.org/D31129#705597, @zturner wrote:
> See what you think about this. I've created a folder called `Mocks` under
> `Utility`, and created a new target out of it. `UtilityTests` links against
> it, and so does `InterpreterTests`. To do this I had
zturner updated this revision to Diff 92373.
zturner added a comment.
See what you think about this. I've created a folder called `Mocks` under
`Utility`, and created a new target out of it. `UtilityTests` links against
it, and so does `InterpreterTests`. To do this I had to add the lldb proj
I thought about something like that too. Let me try to get all these other
patches landed first then I'll think about what to do.
On Mon, Mar 20, 2017 at 9:25 AM Pavel Labath wrote:
> Aha, I see that now. What do you think about creating a test-only module
> that both unit tests can depend on?
Aha, I see that now. What do you think about creating a test-only module
that both unit tests can depend on? The llvm folder-globbing means we would
have to put it in a subfolder (unittests/Utility/lib ?), which makes is
somewhat annoying, but I still think that's better than having the test
code i
The reason was because two different tests from two different unittest
executables need it, but we have no good way to share code across unittests
like this. Open to suggestions though
On Mon, Mar 20, 2017 at 4:02 AM Pavel Labath via Phabricator <
revi...@reviews.llvm.org> wrote:
> labath added in
labath added inline comments.
Comment at: lldb/include/lldb/Utility/TildeExpressionResolver.h:62
+
+class MockTildeExpressionResolver : public TildeExpressionResolver {
+ llvm::StringRef CurrentUser;
I find it very strange to see the Mock object in a regular hea
zturner updated this revision to Diff 92287.
zturner added a comment.
Turns out `ResolveUsername` was only being called from one place outside of
`FileSpec` and `ResolvePartialUsername` was dead code (since callers had
already been updated to use `TildeExpressionResolver`. So I just deleted the
zturner created this revision.
Herald added subscribers: mgorny, srhines.
This is the last step before I plan to move `FileSpec` to `Utility`, which
should completely eliminate between 3 and 5 dependencies from other targets to
`Host`.
https://reviews.llvm.org/D31129
Files:
lldb/include/lld
10 matches
Mail list logo
