[Lldb-commits] [PATCH] D32316: Change UniqueCStringMap to use ConstString as the key

This revision was automatically updated to reflect the committed changes. Closed by commit rL301908: Change UniqueCStringMap to use ConstString as the key (authored by labath). Changed prior to commit: https://reviews.llvm.org/D32316?vs=96629=97417#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D32316: Change UniqueCStringMap to use ConstString as the key

scott.smith added a comment. In https://reviews.llvm.org/D32316#742286, @clayborg wrote: > We can iterate on this. Thank you! Also, can you please push this? I don't have commit access. Repository: rL LLVM https://reviews.llvm.org/D32316

[Lldb-commits] [PATCH] D32316: Change UniqueCStringMap to use ConstString as the key

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. We can iterate on this. Repository: rL LLVM https://reviews.llvm.org/D32316 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D32316: Change UniqueCStringMap to use ConstString as the key

scott.smith added a comment. In https://reviews.llvm.org/D32316#739699, @scott.smith wrote: > Can I get a re-review on this? Thanks. Ping - please rereview! Repository: rL LLVM https://reviews.llvm.org/D32316 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D32316: Change UniqueCStringMap to use ConstString as the key

scott.smith added inline comments. Comment at: include/lldb/Symbol/ObjectFile.h:808-811 + virtual ConstString + StripLinkerSymbolAnnotations(ConstString symbol_name) const { +return symbol_name; } scott.smith wrote: > clayborg wrote: > > This actually

[Lldb-commits] [PATCH] D32316: Change UniqueCStringMap to use ConstString as the key

scott.smith updated this revision to Diff 96629. scott.smith marked 21 inline comments as done. scott.smith added a comment. address review comments Repository: rL LLVM https://reviews.llvm.org/D32316 Files: include/lldb/Core/UniqueCStringMap.h include/lldb/Symbol/ObjectFile.h

[Lldb-commits] [PATCH] D32316: Change UniqueCStringMap to use ConstString as the key

labath added inline comments. Comment at: include/lldb/Interpreter/Property.h:43 + ConstString GetName() const { return m_name; } + ConstString GetDescription() const { return m_description; } scott.smith wrote: > clayborg wrote: > > This shouldn't be

[Lldb-commits] [PATCH] D32316: Change UniqueCStringMap to use ConstString as the key

scott.smith added a comment. At a high level, I think there might be a misunderstanding on what I'm attempting to do. It isn't to convert things that weren't ConstString into things that are. It is instead to utilize the fact that we have all these ConstString in order to improve the

Re: [Lldb-commits] [PATCH] D32316: Change UniqueCStringMap to use ConstString as the key

On Thu, Apr 20, 2017 at 9:00 PM Greg Clayton via Phabricator via lldb-commits wrote: > clayborg requested changes to this revision. > clayborg added a comment. > This revision now requires changes to proceed. > > Very close. A few misuses of ConstString and this will

[Lldb-commits] [PATCH] D32316: Change UniqueCStringMap to use ConstString as the key

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Very close. A few misuses of ConstString and this will be good to go. Comment at: include/lldb/Interpreter/Property.h:43 + ConstString GetName() const {

[Lldb-commits] [PATCH] D32316: Change UniqueCStringMap to use ConstString as the key

jasonmolenda added a comment. You should also add lldb-commits as a subscriber, fwiw, so comments/questions/etc are cc:'ed to the -commits list. Repository: rL LLVM https://reviews.llvm.org/D32316 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D32316: Change UniqueCStringMap to use ConstString as the key

jasonmolenda added a comment. I'd recommend Greg Clayton as a reviewer. Repository: rL LLVM https://reviews.llvm.org/D32316 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D32316: Change UniqueCStringMap to use ConstString as the key

scott.smith created this revision. UniqueCStringMap "sorts" the entries for fast lookup, but really it only cares about uniqueness. ConstString can be compared by pointer along, rather than with strcmp, resulting in much faster comparisons. Change the interface to take ConstString instead,