[Lldb-commits] [PATCH] D32598: Prime module caches outside of the module list lock for better parallelism

jingham closed this revision. jingham added a comment. Sure. Closed with r301609. Repository: rL LLVM https://reviews.llvm.org/D32598 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D32598: Prime module caches outside of the module list lock for better parallelism

scott.smith added a comment. Can someone commit this for me? Thanks! Repository: rL LLVM https://reviews.llvm.org/D32598 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D32598: Prime module caches outside of the module list lock for better parallelism

clayborg accepted this revision. clayborg added a comment. Looks good. Repository: rL LLVM https://reviews.llvm.org/D32598 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D32598: Prime module caches outside of the module list lock for better parallelism

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Looks good. Thanks for working on this! Repository: rL LLVM https://reviews.llvm.org/D32598 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D32598: Prime module caches outside of the module list lock for better parallelism

scott.smith updated this revision to Diff 97002. scott.smith added a comment. Add test to print expression (calls func, hence resolves symbols). Also better parameterize the common test to reduce code duplication. Repository: rL LLVM https://reviews.llvm.org/D32598 Files:

[Lldb-commits] [PATCH] D32598: Prime module caches outside of the module list lock for better parallelism

jingham added a comment. That test is good. That tests the lazy lookup of the dwarf type indices. The other thing this changes is symbol reading. Can you also add a similar test that relies on finding a symbol in a shared library we might not have read in? It probably fine to add it to

[Lldb-commits] [PATCH] D32598: Prime module caches outside of the module list lock for better parallelism

scott.smith updated this revision to Diff 96991. scott.smith added a comment. Fix default param to setup_common so that we actually test both paths. Repository: rL LLVM https://reviews.llvm.org/D32598 Files: include/lldb/Core/Module.h include/lldb/Symbol/SymbolFile.h

[Lldb-commits] [PATCH] D32598: Prime module caches outside of the module list lock for better parallelism

scott.smith updated this revision to Diff 96990. scott.smith added a comment. 1. Rename to preload-symbols / PreloadSymbols() 2. Modify an existing test to run with and without symbol preloading. Repository: rL LLVM https://reviews.llvm.org/D32598 Files: include/lldb/Core/Module.h

[Lldb-commits] [PATCH] D32598: Prime module caches outside of the module list lock for better parallelism

jingham added a comment. Yes, I like that better too. Repository: rL LLVM https://reviews.llvm.org/D32598 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D32598: Prime module caches outside of the module list lock for better parallelism

clayborg added a comment. Would "preload-symbols" be a bit more clear and concise? Repository: rL LLVM https://reviews.llvm.org/D32598 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D32598: Prime module caches outside of the module list lock for better parallelism

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. This is picky but can you call it "symbol-cache-priming". The help text explains it, but this is a very specific cache so we should scope it in case we have some other one later

[Lldb-commits] [PATCH] D32598: Prime module caches outside of the module list lock for better parallelism

jingham added a comment. Ah, sorry. I was talking about an lldb, which you access through the "setting set/get" command. Those are actually implemented by adding a property on the class in question. Look in Target.cpp for the TargetProperties class. You'll just want to add another property

Re: [Lldb-commits] [PATCH] D32598: Prime module caches outside of the module list lock for better parallelism

"(lldb) settings set target.cache-priming foo" On Thu, Apr 27, 2017 at 11:53 AM Scott Smith via Phabricator via lldb-commits wrote: > scott.smith added a comment. > > In https://reviews.llvm.org/D32598#739804, @jingham wrote: > > > Instead of having the cache priming

[Lldb-commits] [PATCH] D32598: Prime module caches outside of the module list lock for better parallelism

scott.smith added a comment. In https://reviews.llvm.org/D32598#739779, @clayborg wrote: > Making an empty main program and saying I see no difference is not enough > testing to enable this. It's not quite an empty main program; it links in 40+ shared libraries with 2M+ symbols. The point

[Lldb-commits] [PATCH] D32598: Prime module caches outside of the module list lock for better parallelism

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. Instead of having the cache priming be determined by platform or something like that, it would be better to add a setting (on the target level seems right) that controls this. I

[Lldb-commits] [PATCH] D32598: Prime module caches outside of the module list lock for better parallelism

clayborg added a comment. Making an empty main program and saying I see no difference is not enough testing to enable this. I also don't see the benefit of this path. When LLDB is used for symbolication, it might never actually load any debug info or symbols from modules that are added to a

[Lldb-commits] [PATCH] D32598: Prime module caches outside of the module list lock for better parallelism

jingham added a reviewer: clayborg. jingham added a comment. Adding Greg as a Reviewer. Repository: rL LLVM https://reviews.llvm.org/D32598 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D32598: Prime module caches outside of the module list lock for better parallelism

scott.smith added a comment. Here's the controversial patch. It has been brought up that the intent is to not load symbols before they are needed, but at least in my experience this patch has no effect on performance when running: lldb -b -o run /path/to/myprogram where myprogram has