labath added a comment.
If you're going to be making drastic changes here, could you please look at the
possibility of making a more targeted test, rather than relying on the "run the
whole debugger and set a breakpoint" type of tests to verify the finer details
of the implementation. I was
scott.smith abandoned this revision.
scott.smith added a comment.
Turns out I'm planning on making more drastic changes to this loop, so there's
no point in reviewing this step.
Repository:
rL LLVM
https://reviews.llvm.org/D32626
___
jingham added a reviewer: clayborg.
jingham added a comment.
Adding Greg as a reviewer. You can generally see from the CODE_OWNERS.txt
file who has overall responsibility for areas in lldb, and you should at least
assign them as a reviewer. For Symbol parsing stuff that's definitely Greg.
