[Lldb-commits] [PATCH] D35734: Don't allow LLDB to try and parse .debug_types

2017-07-24 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. In https://reviews.llvm.org/D35734#819193, @probinson wrote: > In https://reviews.llvm.org/D35734#818778, @tberghammer wrote: > > > This section have been already removed from Dwarf5 so I agree that we > > shouldn't spend too much time adding support for it. > > >

[Lldb-commits] [PATCH] D35734: Don't allow LLDB to try and parse .debug_types

2017-07-24 Thread Phabricator via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL308911: Don't allow .debug_types to be parsed as LLDB can crash when enums are not ableā€¦ (authored by gclayton). Changed prior to commit: https://reviews.llvm.org/D35734?vs=107710=107936#toc

[Lldb-commits] [PATCH] D35734: Don't allow LLDB to try and parse .debug_types

2017-07-24 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. I believe a crash looks like: #include int main(int argc, const char **argv) { typedef enum FooTag { Bar, Baz } Foo; Foo foo = Bar; printf("foo = %i\n", foo); return 0; // Break here and "frame variable" } The enum gets put

[Lldb-commits] [PATCH] D35734: Don't allow LLDB to try and parse .debug_types

2017-07-24 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. The enum might need to be scoped outside the function or in a header file... https://reviews.llvm.org/D35734 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D35734: Don't allow LLDB to try and parse .debug_types

2017-07-24 Thread Tamas Berghammer via Phabricator via lldb-commits
tberghammer accepted this revision. tberghammer added a comment. This revision is now accepted and ready to land. Can you file a bug about this issue so we can keep track of it? Also it would be nice to include a small test case in the bug (if you have one) what demonstrates the crash as so far

[Lldb-commits] [PATCH] D35734: Don't allow LLDB to try and parse .debug_types

2017-07-24 Thread Tamas Berghammer via Phabricator via lldb-commits
tberghammer added a comment. This section have been already removed from Dwarf5 so I agree that we shouldn't spend too much time adding support for it. Do you know anybody hitting this issue? Do you know why they decided to use this flag? Comment at: