This revision was automatically updated to reflect the committed changes.
Closed by commit rL315387: [lldb] Enable using out-of-tree dwps (authored by
alexshap).
Changed prior to commit:
https://reviews.llvm.org/D38568?vs=118250=118504#toc
Repository:
rL LLVM
tberghammer accepted this revision.
tberghammer added a comment.
Looks good. Thanks for fixing it.
Repository:
rL LLVM
https://reviews.llvm.org/D38568
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
Repository:
rL LLVM
https://reviews.llvm.org/D38568
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
alexshap updated this revision to Diff 118250.
alexshap added a comment.
Ignore the UUID comparison if the UUID field is not valid (in this case the
interface seems to be a bit cleaner (module_spec is the single source of truth
(without extra parameters))
Repository:
rL LLVM
clayborg added a comment.
(sorry for the delay, I was out on vacation for a week)
Repository:
rL LLVM
https://reviews.llvm.org/D38568
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
clayborg added inline comments.
Comment at: source/Host/common/Symbols.cpp:288-294
+ // FIXME: at the moment llvm-dwp doesn't output build ids,
+ // nor does binutils dwp. Thus in the case of DWPs
+ // we skip uuids check. This needs to be
tberghammer added inline comments.
Comment at: source/Host/common/Symbols.cpp:288-294
+ // FIXME: at the moment llvm-dwp doesn't output build ids,
+ // nor does binutils dwp. Thus in the case of DWPs
+ // we skip uuids check. This needs to
alexshap added a comment.
Ping
Repository:
rL LLVM
https://reviews.llvm.org/D38568
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
alexshap created this revision.
Herald added subscribers: JDevlieghere, aprantl.
Previously LLDB required dwp to be located next to the executable file
(see the code in SymbolFileDWARF::GetDwpSymbolFile).
This diff uses the helper function Symbols::LocateExecutableSymbolFile
to search for DWP
