zturner added a comment.
Ahh, you might also run the exact same test again but where you've loaded this
inside of main with `LoadLibrary` instead of relying on early binding by the
loader.
https://reviews.llvm.org/D39314
___
lldb-commits mailing l
zturner added a comment.
A test would be something like this:
// dll.cpp
BOOL WINAPI DllMain(HINSTANCE h, DWORD reason, void* reserved) {
return TRUE;
}
int __declspec(dllexport) DllFunc(int n) {
int x = n * n;
return x; // set breakpoint here
}
// main.cpp
int
clayborg added a comment.
Testing would include a test that dynamically loads a shared library and sets a
breakpoint it in. We have these tests, but I am guessing they are disabled on
windows probably because they might use "dlopen(...)" which is probably not
available on windows? I know we hav
davide added a comment.
In https://reviews.llvm.org/D39314#908115, @sas wrote:
> In https://reviews.llvm.org/D39314#908065, @davide wrote:
>
> > can you please try adding a test for this one? :)
>
>
> To be fully honest, I'm not 100% sure how I'm supposed to add tests for this.
> I looked throug
sas added a comment.
In https://reviews.llvm.org/D39314#908065, @davide wrote:
> can you please try adding a test for this one? :)
To be fully honest, I'm not 100% sure how I'm supposed to add tests for this. I
looked through the directories containing unit tests and didn't find anything
spec
davide added a comment.
can you please try adding a test for this one? :)
https://reviews.llvm.org/D39314
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Wow. I didn't realize windows support didn't do any of this. Looks good. Zach
will want to ok this as he is one of the main windows contributors.
https://reviews.llvm.org/D39314
__
sas created this revision.
This commit implements basic DidAttach and DidLaunch for the windows
DynamicLoader plugin which allow us to load shared libraries from the
inferior.
This is an improved version of https://reviews.llvm.org/D12245 and should work
much better.
https://reviews.llvm.org/D
